Skip to content

Commit

Permalink
Update require option to False for os_version in test_reporter.py to …
Browse files Browse the repository at this point in the history
…avoid uploading failure in nightly test (#6015)

What is the motivation for this PR?
In #5992, wrongly add os_version parameter as required True.
It should be false, because if with required True, test_reporter.py will fail to run for current nightly test.
It impacts nightly test, should make it robust with current nightly test yaml file.

How did you do it?
Change it to required False.

How did you verify/test it?
Run nightly test with pipeline.

Signed-off-by: Zhaohui Sun <[email protected]>
  • Loading branch information
ZhaohuiS authored Jul 21, 2022
1 parent 6566245 commit 9acb531
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test_reporting/report_uploader.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def _run_script():
parser.add_argument(
"--testbed", "-t", type=str, help="Name of testbed."
)
os_version = parser.add_mutually_exclusive_group(required=True)
os_version = parser.add_mutually_exclusive_group(required=False)
os_version.add_argument(
"--image_url", "-i", type=str, help="Image url. If has this argument, will ignore version. They are mutually exclusive."
)
Expand Down

0 comments on commit 9acb531

Please sign in to comment.