Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path validator API implementation to validate the gnmi path #76

Merged
merged 5 commits into from
May 22, 2023

Conversation

mbalachandar
Copy link
Contributor

Path validator API implementation to validate the gnmi path, and added following methods.

NewPathValidator() : to create pathValidator type to validate the gnmi path and add the missing module prefix and key names and wild card values in the gnmi path based on the given PathValidatorOpt

Validate() : to validate the path and add the module prefix / wild card keys in the gnmi path based on the given PathValidatorOpt while creating the path validator.

Required for the subscription enhancements as described in HLD sonic-net/SONiC#1287

Copy link

@ndas7 ndas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A few readability comments according to the Go Style Guide.

translib/path/path_validator.go Outdated Show resolved Hide resolved
translib/path/path_validator.go Outdated Show resolved Hide resolved
translib/path/path_validator_test.go Outdated Show resolved Hide resolved
@anand-kumar-subramanian anand-kumar-subramanian merged commit cd51894 into sonic-net:master May 22, 2023
@mbalachandar mbalachandar deleted the path_validator branch July 12, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants