Separate I2C mux state probing and gRPC forwarding state probing #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Table name definitions in this PR should be removed after sonic-net/sonic-swss-common#627 is merged. |
yxieca
approved these changes
Jun 5, 2022
yxieca
pushed a commit
that referenced
this pull request
Jun 5, 2022
What is the motivation for this PR? Current implementation used the same APP DB table for active-active port forwarding state probing and active-standby port mux state probing. This is breaking CLI tests in pre-test. How did you do it? use tables below for active-active port forwarding state probing. #define APP_FORWARDING_STATE_COMMAND_TABLE_NAME "FORWARDING_STATE_COMMAND" #define APP_FORWARDING_STATE_RESPONSE_TABLE_NAME "FORWARDING_STATE_RESPONSE" RESPONSE table expects forwarding state response for both SELF and PEER. Rename some table names & handler functions to avoid confusion. How did you verify/test it? Unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
This PR is to separate I2C mux state probing and gRPC forwarding state probing.
sign-off: Jing Zhang [email protected]
Type of change
Approach
What is the motivation for this PR?
Current implementation used the same APP DB table for active-active port forwarding state probing and active-standby port mux state probing. This is breaking CLI tests in pre-test.
How did you do it?
RESPONSEtable expects forwarding state response for both SELF and PEER.How did you verify/test it?
Unit tests.
Any platform specific information?
Documentation