-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NTP] Update NTP configuration via ConfigDB #60
[NTP] Update NTP configuration via ConfigDB #60
Conversation
Tests will fail until sonic-net/sonic-swss-common#781 will be merged |
64d4f01
to
e46a3aa
Compare
e46a3aa
to
8141e90
Compare
scripts/hostcfgd
Outdated
""" | ||
NTP_CONF_RESTART = ['service', 'ntp-config', 'restart'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is service being used instead of systemctl?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No special reason. Both will work equally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regardless, I think systemctl should be used instead of service here, since the systemctl command is already used in many other places, and this would keep things consistent.
Signed-off-by: Yevhen Fastiuk <[email protected]>
Signed-off-by: Yevhen Fastiuk <[email protected]>
8141e90
to
c2a05e8
Compare
/azpw run sonic-host-services |
1 similar comment
/azpw run sonic-host-services |
/AzurePipelines run sonic-host-services |
No pipelines are associated with this pull request. |
hld [#1296](sonic-net/SONiC#1296) closes [#1254](sonic-net/SONiC#1254) depends-on [#60](sonic-net/sonic-host-services#60), [#781](sonic-net/sonic-swss-common#781), [#2835](sonic-net/sonic-utilities#2835), [#10749](sonic-net/sonic-mgmt#10749) #### Why I did it To cover the next AIs: * Configure NTP global parameters * Add/remove new NTP servers * Change the configuration for NTP servers * Show NTP status * Show NTP configuration ### How I did it * Add YANG model for a new configuration * Extend configuration templates to support new knobs ### Description for the changelog * Add ability to configure NTP global parameters such as authentication, dhcp, admin state * Change the configuration for NTP servers * Add an ability to show NTP configuration #### Link to config_db schema for YANG module changes [NTP configuration](https://github.com/sonic-net/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md#ntp-and-syslog-servers)
hld #1219
closes #1171
This PR brings functionality that allows us to update the NTP configs by writing to the NTP, NTP_SERVER, and NTP_KEY tables of ConfigDB.