-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add execute_reboot dbus_interface #164
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits not particularly related to this PR.
Please update the tests. |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
if rebootmethod in REBOOTMETHOD_COLD_BOOT_VALUES: | ||
cmd = ['/usr/local/bin/reboot'] | ||
elif rebootmethod in REBOOTMETHOD_HALT_BOOT_VALUES: | ||
cmd = ['/usr/local/bin/reboot','-p'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qiluo-msft, this change is upcoming in sonic-utilties which is work-in-progress. If the existing image does not have "-p", command will fail. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this PR could not be merged until the depended PR in other repos merged first.
As part of sonic-net/sonic-gnmi#286 changes, we require dbus support for executing HALT method.
This PR adds support for execute_reboot for invoking reboot methods.