Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open different socket to enable interface filtering for dual tor scenario #10

Merged
merged 10 commits into from
Sep 19, 2022
Merged

Open different socket to enable interface filtering for dual tor scenario #10

merged 10 commits into from
Sep 19, 2022

Conversation

kellyyeh
Copy link
Collaborator

@kellyyeh kellyyeh commented Aug 3, 2022

Why I did it
Raw sockets are used for receiving packets and acl rules are not able to block dhcpv6 packets from being received by dhcp6relay raw sockets.

How I did it
To accommodate dual tor scenario, recvfrom is used to filter out interfaces. If the interface mux status is standby, dhcp6relay does not relay the packet.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 3, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@lgtm-com
Copy link

lgtm-com bot commented Aug 3, 2022

This pull request introduces 1 alert when merging 3c0c947 into 6f94c2e - view on LGTM.com

new alerts:

  • 1 for Short global name

saiarcot895
saiarcot895 reviewed Aug 3, 2022
View reviewed changes
src/relay.cpp Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Aug 9, 2022

This pull request introduces 1 alert when merging f293f71 into 6f94c2e - view on LGTM.com

new alerts:

  • 1 for Short global name

@kellyyeh kellyyeh force-pushed the gemini branch 3 times, most recently from 27d8a0d to d76b35c Compare August 22, 2022 22:42
@lgtm-com
Copy link

lgtm-com bot commented Aug 22, 2022

This pull request introduces 1 alert when merging 8c1339c into 3c4a940 - view on LGTM.com

new alerts:

  • 1 for Short global name

saiarcot895
saiarcot895 reviewed Aug 24, 2022
View reviewed changes
src/main.cpp Outdated Show resolved Hide resolved
@saiarcot895
Copy link
Collaborator

With this change, src/relay.cpp will be almost 1000 lines. I think it might be worth it for maintainability purposes to reorganize this file in the future. Maybe split it into separate files, or use C++ classes to group functions and structures used?

yxieca
yxieca reviewed Aug 24, 2022
View reviewed changes
src/relay.cpp Show resolved Hide resolved
@kellyyeh
Copy link
Collaborator Author

With this change, src/relay.cpp will be almost 1000 lines. I think it might be worth it for maintainability purposes to reorganize this file in the future. Maybe split it into separate files, or use C++ classes to group functions and structures used?

Agreed, I will create another PR for this.

@kellyyeh kellyyeh merged commit 9c3b738 into sonic-net:master Sep 19, 2022
@kellyyeh kellyyeh deleted the gemini branch September 19, 2022 05:31
@kellyyeh kellyyeh restored the gemini branch September 19, 2022 05:31
qiluo-msft pushed a commit that referenced this pull request Sep 21, 2022
@kellyyeh @qiluo-msft
Open different socket to enable interface filtering for dual tor scen…
b3cdec9 
…ario (#10)
kellyyeh added a commit to kellyyeh/sonic-dhcp-relay that referenced this pull request Oct 8, 2022
@kellyyeh
Open different socket to enable interface filtering for dual tor scen…
951cdc6 
…ario (sonic-net#10)
kellyyeh added a commit to kellyyeh/sonic-dhcp-relay that referenced this pull request Oct 10, 2022
@kellyyeh
Open different socket to enable interface filtering for dual tor scen…
ea4570a 
…ario (sonic-net#10)
@kellyyeh kellyyeh mentioned this pull request Oct 20, 2022
Merged
7 tasks
@vivekrnv vivekrnv mentioned this pull request Nov 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxieca yxieca yxieca approved these changes

@saiarcot895 saiarcot895 saiarcot895 approved these changes

Assignees
No one assigned
Labels
Included in 202012 Branch Request for 202012 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kellyyeh @saiarcot895 @yxieca @qiluo-msft