Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RouteRule action_type field #28

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix RouteRule action_type field #28

wants to merge 1 commit into from

Conversation

theasianpianist
Copy link
Collaborator

  • The action_type field in the RouteRule message is currently defined as a route_type.RoutingType value (e.g. privatelink, servicetunnel, etc.). However, based on the DASH HLD this field needs to contain route_type.ActionType values (e.g. decap, maprouting, etc.)
  • Change the action_type field to route_type.ActionType value and update related tests

@theasianpianist theasianpianist marked this pull request as draft August 29, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pterosaur Pterosaur Awaiting requested review from Pterosaur

@prsunny prsunny Awaiting requested review from prsunny

@prabhataravind prabhataravind Awaiting requested review from prabhataravind

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@theasianpianist