Enable dbgsym package for dhcpmon #9862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saikrishna Arcot <[email protected]>
saiarcot895
requested review from
lguohan,
qiluo-msft and
xumia
as code owners
yxieca
previously approved these changes
Jan 27, 2022
Also, use LDFLAGS when linking dhcp6relay. These two changes make sure the flags set in environment variables (by dpkg-buildflags) are honored. Also, explicitly enable all hardening flags in dpkg-buildflags for dhcp6relay and dhcpmon. The change from the default set of flags is that during linking, immediate binding of symbols is done instead of lazy binding. Signed-off-by: Saikrishna Arcot <[email protected]>
yxieca
approved these changes
Jan 27, 2022
kellyyeh
approved these changes
Jan 27, 2022
|
This commit could not be cleanly cherry-picked to 202012. Please submit another PR. |
yxieca
pushed a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Feb 10, 2022
…#9862) Enable dbgsym package for dhcpmon. Allow CFLAGS and LDFLAGS from environment variables to be used in the dhcp6relay build. This makes sure that the -O2 flag from dpkg-buildflags gets used. Finally, enable all hardening flags in dpkg-buildflags for dhcp6relay and dhcpmon. The change from the default set of flags is that during linking, immediate binding of symbols is done instead of lazy binding. Signed-off-by: Saikrishna Arcot <[email protected]>
yxieca
pushed a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Feb 10, 2022
…#9862) Enable dbgsym package for dhcpmon. Allow CFLAGS and LDFLAGS from environment variables to be used in the dhcp6relay build. This makes sure that the -O2 flag from dpkg-buildflags gets used. Finally, enable all hardening flags in dpkg-buildflags for dhcp6relay and dhcpmon. The change from the default set of flags is that during linking, immediate binding of symbols is done instead of lazy binding. Signed-off-by: Saikrishna Arcot <[email protected]>
yxieca
added a commit
that referenced
this pull request
Feb 11, 2022
…9862) (#9960) Enable dbgsym package for dhcpmon. Allow CFLAGS and LDFLAGS from environment variables to be used in the dhcp6relay build. This makes sure that the -O2 flag from dpkg-buildflags gets used. Finally, enable all hardening flags in dpkg-buildflags for dhcp6relay and dhcpmon. The change from the default set of flags is that during linking, immediate binding of symbols is done instead of lazy binding. Signed-off-by: Saikrishna Arcot <[email protected]> Co-authored-by: Saikrishna Arcot <[email protected]>
yxieca
added a commit
that referenced
this pull request
Feb 11, 2022
…9959) * dhcp6relay: Save the dbgsym package into the target folder (#9013) This makes it possible to install the debug symbols if needed. Also install the package into the debug version of sonic-dhcp-relay container. Signed-off-by: Saikrishna Arcot <[email protected]> * Package debugging and hardening for dhcpmon and dhcp6relay (#9862) Enable dbgsym package for dhcpmon. Allow CFLAGS and LDFLAGS from environment variables to be used in the dhcp6relay build. This makes sure that the -O2 flag from dpkg-buildflags gets used. Finally, enable all hardening flags in dpkg-buildflags for dhcp6relay and dhcpmon. The change from the default set of flags is that during linking, immediate binding of symbols is done instead of lazy binding. Signed-off-by: Saikrishna Arcot <[email protected]> * [201811][dhcp] update debian build rules Signed-off-by: Ying Xie <[email protected]> Co-authored-by: Saikrishna Arcot <[email protected]>
kellyyeh
added
the
Request for 202111 Branch
|
@saiarcot895 Please create a separate PR for 202111 branch as there are conflicts |
judyjoseph
removed
the
Request for 202111 Branch
saiarcot895
added a commit
to saiarcot895/sonic-buildimage
that referenced
this pull request
Feb 22, 2022
…#9862) Enable dbgsym package for dhcpmon. Allow CFLAGS and LDFLAGS from environment variables to be used in the dhcp6relay build. This makes sure that the -O2 flag from dpkg-buildflags gets used. Finally, enable all hardening flags in dpkg-buildflags for dhcp6relay and dhcpmon. The change from the default set of flags is that during linking, immediate binding of symbols is done instead of lazy binding. Signed-off-by: Saikrishna Arcot <[email protected]>
6 tasks
saiarcot895
added a commit
that referenced
this pull request
Feb 25, 2022
…10063) Enable dbgsym package for dhcpmon. Allow CFLAGS and LDFLAGS from environment variables to be used in the dhcp6relay build. This makes sure that the -O2 flag from dpkg-buildflags gets used. Finally, enable all hardening flags in dpkg-buildflags for dhcp6relay and dhcpmon. The change from the default set of flags is that during linking, immediate binding of symbols is done instead of lazy binding. Signed-off-by: Saikrishna Arcot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Saikrishna Arcot [email protected]
Why I did it
Copy out the dbgsym package for dhcpmon, to assist in debugging if needed
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)