Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox][VXLAN] add params to vxlan.json file in order to configure VXLAN src port range feature #9658

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

ayurkiv-nvda
Copy link
Contributor

@ayurkiv-nvda ayurkiv-nvda commented Dec 29, 2021

Why I did it

Need to:

  • remove obsolete parameter that enables static VXLAN src port range
  • provide functionality no generate json config file according to appropriate parameter in config_db

Done for
SN3800:
• Mellanox-SN3800-D28C50
• Mellanox-SN3800-C64
• Mellanox-SN3800-D28C49S1 (New 10G SKU)

SN2700:
• Mellanox-SN2700-D48C8

How I did it

  • Remove SAI_VXLAN_SRCPORT_RANGE_ENABLE=1 from appropriate sai.profile files
  • Created vxlan.json file and added few params that depends on DEVICE_METADATA.localhost.vxlan_port_range

How to verify it

File /etc/swss/config.d/vxlan.json should be generated inside swss docker when it restart

[
    {
        "SWITCH_TABLE:switch": {
            "vxlan_src": "0xFF00",
            "vxlan_mask": "8"
        },
        "OP": "SET"
    }
]

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@liat-grozovik
Copy link
Collaborator

@ayurkiv-nvda as this is pending SAI update, can you please add reference to the SAI PR? please check if this is the PR #9619

@dprital dprital added the Request for 202111 Branch For PRs being requested for 202111 branch label Jan 18, 2022
@liat-grozovik liat-grozovik marked this pull request as ready for review January 27, 2022 11:48
@liat-grozovik liat-grozovik requested review from prsunny and removed request for lguohan, qiluo-msft, prgeor, sujinmkang, xumia and vdahiya12 January 27, 2022 11:50
@liat-grozovik liat-grozovik merged commit cb3b941 into sonic-net:master Jan 31, 2022
liat-grozovik pushed a commit that referenced this pull request Feb 13, 2022
…eature (#9956)

- Why I did it
Need to remove old static configs from sai.profile files.
New implementation: sonic-net/sonic-swss#1959
New configuration: #9658

- How I did it
Remove SAI_VXLAN_SRCPORT_RANGE_ENABLE=1 lines from files per HWSKU

- How to verify it
When static config is removed following test will fail (src port will be in range 0-255)

py.test vxlan/test_vnet_vxlan.py --inventory "../ansible/inventory, ../ansible/veos" --host-pattern (testbed)-t0 --module-path ../ansible/library/ --testbed (testbed)-t0 --testbed_file ../ansible/testbed.csv --allow_recover --assert plain --log-cli-level info --show-capture=no -ra --showlocals --disable_loganalyzer --skip_sanity --upper_bound_udp_port 65535 --lower_bound_udp_port 64128
judyjoseph pushed a commit that referenced this pull request Feb 14, 2022
… VXLAN src port range feature (#9658)

- Why I did it
Remove obsolete parameter that enables static VXLAN src port range
provide functionality no generate json config file according to appropriate parameter in config_db
Done for
SN3800:
• Mellanox-SN3800-D28C50
• Mellanox-SN3800-C64
• Mellanox-SN3800-D28C49S1 (New 10G SKU)

SN2700:
• Mellanox-SN2700-D48C8

- How I did it
Remove SAI_VXLAN_SRCPORT_RANGE_ENABLE=1 from appropriate sai.profile files
Created vxlan.json file and added few params that depends on DEVICE_METADATA.localhost.vxlan_port_range

- How to verify it
File /etc/swss/config.d/vxlan.json should be generated inside swss docker when it restart
[
    {
        "SWITCH_TABLE:switch": {
            "vxlan_src": "0xFF00",
            "vxlan_mask": "8"
        },
        "OP": "SET"
    }
]
Signed-off-by: Andriy Yurkiv <[email protected]>
judyjoseph pushed a commit that referenced this pull request Feb 14, 2022
…eature (#9956)

- Why I did it
Need to remove old static configs from sai.profile files.
New implementation: sonic-net/sonic-swss#1959
New configuration: #9658

- How I did it
Remove SAI_VXLAN_SRCPORT_RANGE_ENABLE=1 lines from files per HWSKU

- How to verify it
When static config is removed following test will fail (src port will be in range 0-255)

py.test vxlan/test_vnet_vxlan.py --inventory "../ansible/inventory, ../ansible/veos" --host-pattern (testbed)-t0 --module-path ../ansible/library/ --testbed (testbed)-t0 --testbed_file ../ansible/testbed.csv --allow_recover --assert plain --log-cli-level info --show-capture=no -ra --showlocals --disable_loganalyzer --skip_sanity --upper_bound_udp_port 65535 --lower_bound_udp_port 64128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants