-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox][VXLAN] add params to vxlan.json file in order to configure VXLAN src port range feature #9658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andriy Yurkiv <[email protected]>
… VXLAN src port range feature Signed-off-by: Andriy Yurkiv <[email protected]>
@ayurkiv-nvda as this is pending SAI update, can you please add reference to the SAI PR? please check if this is the PR #9619 |
dprital
added
the
Request for 202111 Branch
For PRs being requested for 202111 branch
label
Jan 18, 2022
liat-grozovik
requested review from
lguohan,
prgeor,
qiluo-msft,
sujinmkang,
vdahiya12 and
xumia
as code owners
January 27, 2022 11:48
liat-grozovik
requested review from
prsunny
and removed request for
lguohan,
qiluo-msft,
prgeor,
sujinmkang,
xumia and
vdahiya12
January 27, 2022 11:50
liat-grozovik
approved these changes
Jan 27, 2022
volodymyrsamotiy
approved these changes
Jan 31, 2022
5 tasks
liat-grozovik
pushed a commit
that referenced
this pull request
Feb 13, 2022
…eature (#9956) - Why I did it Need to remove old static configs from sai.profile files. New implementation: sonic-net/sonic-swss#1959 New configuration: #9658 - How I did it Remove SAI_VXLAN_SRCPORT_RANGE_ENABLE=1 lines from files per HWSKU - How to verify it When static config is removed following test will fail (src port will be in range 0-255) py.test vxlan/test_vnet_vxlan.py --inventory "../ansible/inventory, ../ansible/veos" --host-pattern (testbed)-t0 --module-path ../ansible/library/ --testbed (testbed)-t0 --testbed_file ../ansible/testbed.csv --allow_recover --assert plain --log-cli-level info --show-capture=no -ra --showlocals --disable_loganalyzer --skip_sanity --upper_bound_udp_port 65535 --lower_bound_udp_port 64128
judyjoseph
pushed a commit
that referenced
this pull request
Feb 14, 2022
… VXLAN src port range feature (#9658) - Why I did it Remove obsolete parameter that enables static VXLAN src port range provide functionality no generate json config file according to appropriate parameter in config_db Done for SN3800: • Mellanox-SN3800-D28C50 • Mellanox-SN3800-C64 • Mellanox-SN3800-D28C49S1 (New 10G SKU) SN2700: • Mellanox-SN2700-D48C8 - How I did it Remove SAI_VXLAN_SRCPORT_RANGE_ENABLE=1 from appropriate sai.profile files Created vxlan.json file and added few params that depends on DEVICE_METADATA.localhost.vxlan_port_range - How to verify it File /etc/swss/config.d/vxlan.json should be generated inside swss docker when it restart [ { "SWITCH_TABLE:switch": { "vxlan_src": "0xFF00", "vxlan_mask": "8" }, "OP": "SET" } ] Signed-off-by: Andriy Yurkiv <[email protected]>
judyjoseph
pushed a commit
that referenced
this pull request
Feb 14, 2022
…eature (#9956) - Why I did it Need to remove old static configs from sai.profile files. New implementation: sonic-net/sonic-swss#1959 New configuration: #9658 - How I did it Remove SAI_VXLAN_SRCPORT_RANGE_ENABLE=1 lines from files per HWSKU - How to verify it When static config is removed following test will fail (src port will be in range 0-255) py.test vxlan/test_vnet_vxlan.py --inventory "../ansible/inventory, ../ansible/veos" --host-pattern (testbed)-t0 --module-path ../ansible/library/ --testbed (testbed)-t0 --testbed_file ../ansible/testbed.csv --allow_recover --assert plain --log-cli-level info --show-capture=no -ra --showlocals --disable_loganalyzer --skip_sanity --upper_bound_udp_port 65535 --lower_bound_udp_port 64128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Included in 202111 Branch
Platform: Mellanox
Request for 202111 Branch
For PRs being requested for 202111 branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Need to:
Done for
SN3800:
• Mellanox-SN3800-D28C50
• Mellanox-SN3800-C64
• Mellanox-SN3800-D28C49S1 (New 10G SKU)
SN2700:
• Mellanox-SN2700-D48C8
How I did it
How to verify it
File /etc/swss/config.d/vxlan.json should be generated inside swss docker when it restart
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)