Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CoPP] Add always_enabled field #9302

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

noaOrMlnx
Copy link
Collaborator

Why I did it

Add the "always_enabled" field to copp_cfg.j2 file, in order to allow traps without an entry in features table, to be installed automatically.

How I did it

Add the new field, and changed the logic in sonic-swss.
In addition, add all of the enabled features to init_cfg.json.j2 file in order to have the UT passing.

How to verify it

Check that arp, udld, ip2me and lacp traps are auto installed, and traps that has no feature entry are not auto installed.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

dgsudharsan
dgsudharsan previously approved these changes Nov 22, 2021
prsunny
prsunny previously approved these changes Nov 22, 2021
@qiluo-msft
Copy link
Collaborator

Seems lgtm feel difficult to fetch old commit on your forked repo. Could you rebase your commits onto latest master?

@noaOrMlnx
Copy link
Collaborator Author

Seems lgtm feel difficult to fetch old commit on your forked repo. Could you rebase your commits onto latest master

@qiluo-msft
Done

@prsunny
Copy link
Contributor

prsunny commented Nov 23, 2021

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny
Copy link
Contributor

prsunny commented Nov 30, 2021

@dgsudharsan , please sign-off

@prsunny prsunny merged commit 0908f9e into sonic-net:master Nov 30, 2021
@qiluo-msft
Copy link
Collaborator

This commit could not be cleanly cherry-picked to 202012. Please submit another PR.

liat-grozovik pushed a commit to sonic-net/sonic-swss that referenced this pull request Jan 26, 2022
- What I did
Add the new design for copp manager - always_enabled field in copp_cfg.json file.

- Why I did it
A change was done for traps needs to be installed but doesn't have feature (arp, udld, lacp, ip2me),
in the new implementation, coppmgr will not automatically install traps which has no entry in features table, but will check first if the trap has "always_enabled":"true" field.

- How I verified it
run tests for making sure traps are installed and not when expecting them to.

- Details if related
Related to sonic-buildimage change - sonic-net/sonic-buildimage#9302
SONiC mgmt test plan can be found in sonic-net/SONiC#903.
judyjoseph pushed a commit to sonic-net/sonic-swss that referenced this pull request Jan 31, 2022
- What I did
Add the new design for copp manager - always_enabled field in copp_cfg.json file.

- Why I did it
A change was done for traps needs to be installed but doesn't have feature (arp, udld, lacp, ip2me),
in the new implementation, coppmgr will not automatically install traps which has no entry in features table, but will check first if the trap has "always_enabled":"true" field.

- How I verified it
run tests for making sure traps are installed and not when expecting them to.

- Details if related
Related to sonic-buildimage change - sonic-net/sonic-buildimage#9302
SONiC mgmt test plan can be found in sonic-net/SONiC#903.
@prsunny
Copy link
Contributor

prsunny commented Feb 11, 2022

Please raise a separate PR for 202012

noaOrMlnx added a commit to noaOrMlnx/sonic-swss that referenced this pull request Feb 16, 2022
- What I did
Add the new design for copp manager - always_enabled field in copp_cfg.json file.

- Why I did it
A change was done for traps needs to be installed but doesn't have feature (arp, udld, lacp, ip2me),
in the new implementation, coppmgr will not automatically install traps which has no entry in features table, but will check first if the trap has "always_enabled":"true" field.

- How I verified it
run tests for making sure traps are installed and not when expecting them to.

- Details if related
Related to sonic-buildimage change - sonic-net/sonic-buildimage#9302
SONiC mgmt test plan can be found in sonic-net/SONiC#903.
noaOrMlnx added a commit to noaOrMlnx/sonic-buildimage that referenced this pull request Feb 16, 2022
*Add the "always_enabled" field to copp_cfg.j2 file, in order to allow traps without an entry in features table, to be installed automatically.
@noaOrMlnx noaOrMlnx mentioned this pull request Feb 16, 2022
6 tasks
liat-grozovik pushed a commit that referenced this pull request Feb 20, 2022
Add the "always_enabled" field to copp_cfg.j2 file, in order to allow traps without an entry in features table, to be installed automatically.

This is a cherry-pick of #9302

- Why I did it
In order to allow traps without an entry in features table, to be installed automatically.

- How I did it
Add always_enabled field to traps without a feature
arlakshm pushed a commit that referenced this pull request Mar 1, 2022
*Add the "always_enabled" field to copp_cfg.j2 file, in order to allow traps without an entry in features table, to be installed automatically.
preetham-singh pushed a commit to preetham-singh/sonic-swss that referenced this pull request Aug 6, 2022
- What I did
Add the new design for copp manager - always_enabled field in copp_cfg.json file.

- Why I did it
A change was done for traps needs to be installed but doesn't have feature (arp, udld, lacp, ip2me),
in the new implementation, coppmgr will not automatically install traps which has no entry in features table, but will check first if the trap has "always_enabled":"true" field.

- How I verified it
run tests for making sure traps are installed and not when expecting them to.

- Details if related
Related to sonic-buildimage change - sonic-net/sonic-buildimage#9302
SONiC mgmt test plan can be found in sonic-net/SONiC#903.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Coppmgr] Disable traps that are not explicitly present in feature table
7 participants