[build] Fix armhf and arm64 build break #9196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR# 8366 added grpcio for both python2 and python 3 to the Sonic build. The python2 installation is failing for both armhf and arm64. This commit removes grpcio from the build of ARM based platforms as it is not currently needed.
lguohan
reviewed
Nov 8, 2021
| sudo https_proxy=$https_proxy LANG=C chroot $FILESYSTEM_ROOT pip2 install "grpcio==1.39.0" | ||
| sudo https_proxy=$https_proxy LANG=C chroot $FILESYSTEM_ROOT pip2 install "grpcio-tools==1.39.0" | ||
| sudo https_proxy=$https_proxy LANG=C chroot $FILESYSTEM_ROOT pip3 install "grpcio==1.39.0" | ||
| sudo https_proxy=$https_proxy LANG=C chroot $FILESYSTEM_ROOT pip3 install "grpcio-tools==1.39.0" |
There was a problem hiding this comment.
grpcio is supported for python3. We can also wait till #8191 is merged to address the master issue.
There was a problem hiding this comment.
I considered leaving the pip3 install in place but in the end jettisoned the whole thing. Probably not the best approach. I'm fine with waiting for PR 8191. Hoping that doesn't take too long. Don't want to not have armhf build regression coverage for too long.
|
The upcoming upgrade to Bullseye removes python2 support for grpcio and thus avoids this build failure. This will fix the master branch build break for ARM. Thus I am closing this PR. We can address the build break in the 202106 branch in a later PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
PR# 8366 added grpcio for both python2 and python 3 to the Sonic build. The
python2 installation is failing for both armhf and arm64. This commit removes
grpcio from the build of ARM based platforms as it is not currently needed.
How I did it
Remove grpcio and grpcio-tools python package installation from target filesystem for all but the amd64 platform.
How to verify it
Build the armhf and arm64 platforms
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)