Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docker-sonic-vs] Removing fake_platform environment variable #9175

Merged
merged 1 commit into from
Nov 5, 2021

Conversation

dgsudharsan
Copy link
Collaborator

… used

Signed-off-by: Sudharsan Dhamal Gopalarathnam [email protected]

Why I did it

Removing fake_platform environment variable. Following the merge of #9044 and sonic-net/sonic-swss#1978 the fake_platform environment variable is not used in any place and removing the stale references.

How I did it

Cleaned up the places where it is used

How to verify it

Successful execution of vs tests would ensure it is verified.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@dgsudharsan dgsudharsan requested a review from lguohan as a code owner November 4, 2021 21:13
@dgsudharsan
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dgsudharsan
Copy link
Collaborator Author

@kcudnik @lguohan @prsunny Can you please review and signoff?

@prsunny prsunny merged commit 738de2d into sonic-net:master Nov 5, 2021
@dgsudharsan dgsudharsan deleted the fake_platform_cleanup branch March 9, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants