Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[centec] Support saiserver docker for centec-x86 and centec-arm64 platform #9162

Conversation

guxianghong
Copy link
Contributor

Why I did it

  1. Fix docker-syncd-centec-rpc.gz compile fail
  2. Support Centec saiserver docker

How I did it

  1. Modify related Makefiles in platform/centec and platform/centec-arm64

How to verify it

  1. For centec x86 platform, use "make configure PLATFORM=centec" and "BLDENV=buster make -f Makefile.work target/docker-syncd-centec-rpc.gz" to compile
  2. For centec x86 platform, use "make configure PLATFORM=centec-arm64 PLATFORM_ARCH=arm64" and "BLDENV=buster make -f Makefile.work target/docker-syncd-centec-rpc.gz" to compile

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@guxianghong guxianghong requested a review from lguohan as a code owner November 3, 2021 10:32
@lguohan
Copy link
Collaborator

lguohan commented Nov 4, 2021

@richardyu-ms to check.

@guxianghong guxianghong force-pushed the xgu_develop_sonic_master_support_saiserver_docker branch from 00a6af7 to 92516c9 Compare November 5, 2021 02:53
richardyu-ms
richardyu-ms previously approved these changes Nov 7, 2021
Copy link
Contributor

@richardyu-ms richardyu-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no change happed in file platform/centec-arm64/tsingma-bsp/debian/rules?

@richardyu-ms richardyu-ms self-requested a review November 7, 2021 14:32
@guxianghong
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@guxianghong
Copy link
Contributor Author

/azpw run LGTM analysis: Python

@mssonicbld
Copy link
Collaborator

/AzurePipelines run LGTM analysis: Python

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@guxianghong
Copy link
Contributor Author

no change happed in file platform/centec-arm64/tsingma-bsp/debian/rules?

The permissions on this file will be automatically changed to 100755, so I'm submitting it along with this PR.

@guxianghong
Copy link
Contributor Author

It seems this PR is pending on "LGTM analysis: Python Expected — Waiting for status to be reported",
Could you help to retest it, Thanks, @richardyu-ms .

@guxianghong guxianghong closed this Nov 8, 2021
@guxianghong guxianghong reopened this Nov 8, 2021
@richardyu-ms
Copy link
Contributor

It seems this PR is pending on "LGTM analysis: Python Expected — Waiting for status to be reported", Could you help to retest it, Thanks, @richardyu-ms .

looks like LGTM did not find any code for analyzing.

@richardyu-ms
Copy link
Contributor

for this file platform/centec-arm64/tsingma-bsp/debian/rules, looks like it is not changed.

@guxianghong
Copy link
Contributor Author

for this file platform/centec-arm64/tsingma-bsp/debian/rules, looks like it is not changed.

The permission mode of this file have been changed: 100644 → 100755

@guxianghong
Copy link
Contributor Author

It seems this PR is pending on "LGTM analysis: Python Expected — Waiting for status to be reported", Could you help to retest it, Thanks, @richardyu-ms .

looks like LGTM did not find any code for analyzing.

I have retest this PR by close and reopen it. The final status is correct now.

@guxianghong
Copy link
Contributor Author

@lguohan @richardyu-ms Please help to review and merge this PR, Thanks.

@richardyu-ms richardyu-ms dismissed their stale review November 11, 2021 07:15

some questions need to be addressed

@guxianghong
Copy link
Contributor Author

@richardyu-ms Thanks for review,
Please help to merge this PR @lguohan, Thanks.

@lguohan lguohan merged commit bb798a3 into sonic-net:master Nov 16, 2021
@guxianghong guxianghong deleted the xgu_develop_sonic_master_support_saiserver_docker branch December 22, 2021 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants