-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sfp-refactoring] Initial support for CMIS application initialization #9157
Conversation
which sfp refactor framework are you referring to? is it arista one or broadcom one? |
It's Broadcom, but the new sfp-refactoring is still in-progress, and should be ready by this Friday |
This pull request introduces 1 alert when merging ec1fddf25298a761272f89a939d511661c9f3766 into a61ffcd - view on LGTM.com new alerts:
|
dad90ab
to
6c9d950
Compare
Returns: | ||
A string, the port/cage type of this SFP | ||
""" | ||
return self.SFP_PORT_TYPE_QSFPDD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this (at least ideally) be based on byte 00 from the plugged in module?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the cage type of the port, not the media type fetched from the EEPROM of the attached transceiver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack, thanks.
1b033fc
to
2df4e38
Compare
2df4e38
to
7fe760c
Compare
/azpw run |
/AzurePipelines run |
Pull request contains merge conflicts. |
…ework Migrate the Quanta IX9 to the new sfp-refactoring framework Signed-off-by: Dante Su <[email protected]>
7fe760c
to
62d57b0
Compare
[sfp-refactoring] Quanta IX9: migrate to the new sfp-refactoring framework
Migrate the Quanta IX9 to the new sfp-refactoring framework
Signed-off-by: Dante Su [email protected]
Why I did it
Migrate the Quanta IX9 to the new sfp-refactoring framework
How I did it
Update the sfp.py of Quanta IX9 to use the new sfp-refactoring framework
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)