[build] Use pip to install setup.py dependency instead of python setup.py install
#9111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xumia
approved these changes
Oct 29, 2021
saiarcot895
approved these changes
Oct 29, 2021
saiarcot895
reviewed
Oct 29, 2021
| @@ -620,6 +620,8 @@ $(addprefix $(PYTHON_WHEELS_PATH)/, $(SONIC_PYTHON_WHEELS)) : $(PYTHON_WHEELS_PA | |||
| pushd $($*_SRC_PATH) $(LOG_SIMPLE) | |||
| # apply series of patches if exist | |||
| if [ -f ../$(notdir $($*_SRC_PATH)).patch/series ]; then QUILT_PATCHES=../$(notdir $($*_SRC_PATH)).patch quilt push -a; fi | |||
| # Use pip instead of later setup.py to install dependencies into user home, but uninstall self | |||
| pip$($*_PYTHON_VERSION) install . && pip$($*_PYTHON_VERSION) uninstall --yes `python setup.py --name` | |||
There was a problem hiding this comment.
python setup.py --name should be python$($*_PYTHON_VERSION) setup.py --name
There was a problem hiding this comment.
Good catch! It is working now, and I will fix later in anther PR.
guxianghong
pushed a commit
to CentecNetworks/sonic-buildimage
that referenced
this pull request
May 21, 2022
…up.py install` (sonic-net#9111) #### Why I did it Backport sonic-net#8997 to 202012 branch.
liuyuefengcn
added a commit
to liuyuefengcn/sonic-net-buildimage
that referenced
this pull request
Nov 14, 2023
SHA-1: 798910a * [build] Use pip to install setup.py dependency instead of `python setup.py install` (sonic-net#9111) #### Why I did it Backport sonic-net#8997 to 202012 branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Backport #8997 to 202012 branch.
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)