[minigraph] Add tagged vlan member support for storage backend #9045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neetha John <[email protected]>
Signed-off-by: Neetha John <[email protected]>
neethajohn
changed the title
yxieca
approved these changes
Oct 25, 2021
prsunny
approved these changes
Oct 27, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Oct 29, 2021
Signed-off-by: Neetha John <[email protected]> Why I did it Storage T0's have all vlan members as tagged How I did it Since currently minigraph does not have a unique way to identify if a vlan member is tagged/untagged and to ensure other scenarios are not broken, the logic used is to just update the vlan member type as 'tagged' when we determine that it is a storage backend device. This change will apply only to storage backend T0's since storage backend T1's will not have vlan member information How to verify it Updated the storage backend T0 testcases to check for tagged vlan members Added testcase to check if a T1 and backend T1 device generates an empty vlan member table Existing vlan member testcases are good enough for checking if any regression has been caused for regular T0's Build sonic_config_engine-1.0-py3-none-any.whl successfully
judyjoseph
pushed a commit
that referenced
this pull request
Nov 14, 2021
Signed-off-by: Neetha John <[email protected]> Why I did it Storage T0's have all vlan members as tagged How I did it Since currently minigraph does not have a unique way to identify if a vlan member is tagged/untagged and to ensure other scenarios are not broken, the logic used is to just update the vlan member type as 'tagged' when we determine that it is a storage backend device. This change will apply only to storage backend T0's since storage backend T1's will not have vlan member information How to verify it Updated the storage backend T0 testcases to check for tagged vlan members Added testcase to check if a T1 and backend T1 device generates an empty vlan member table Existing vlan member testcases are good enough for checking if any regression has been caused for regular T0's Build sonic_config_engine-1.0-py3-none-any.whl successfully
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Storage T0's have all vlan members as tagged
How I did it
Since currently minigraph does not have a unique way to identify if a vlan member is tagged/untagged and to ensure other scenarios are not broken, the logic used is to just update the vlan member type as 'tagged' when we determine that it is a storage backend device. This change will apply only to storage backend T0's since storage backend T1's will not have vlan member information
How to verify it
Build sonic_config_engine-1.0-py3-none-any.whl successfully
Which release branch to backport (provide reason below if selected)