Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bash] Fix bash build break when re-build bash issue. #9027

Merged
merged 1 commit into from
Oct 22, 2021
Merged

[Bash] Fix bash build break when re-build bash issue. #9027

merged 1 commit into from
Oct 22, 2021

Conversation

liuh-80
Copy link
Contributor

@liuh-80 liuh-80 commented Oct 21, 2021

This pull request will fix bash build break issue when re-build bash.

Why I did it

src/bash project using quilt to manage patches, and quilt can't apply patch correctly when cache folder '.pc' is not clean.

How I did it

Add command in make file to remove quilt cache folder before apply patches.

How to verify it

Re-build bash target target/debs/buster/bash_5.1-2_amd64.deb to validate this fix work.
Pass all UT.

Which release branch to backport (provide reason below if selected)

N/A

Description for the changelog

Fix bash build break issue when re-build bash.

A picture of a cute animal (not mandatory but encouraged)

@liuh-80 liuh-80 requested a review from lguohan as a code owner October 21, 2021 05:37
@liuh-80 liuh-80 requested a review from qiluo-msft October 21, 2021 05:57
@liuh-80 liuh-80 merged commit 5b5f3f0 into sonic-net:master Oct 22, 2021
@liuh-80 liuh-80 mentioned this pull request Jul 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@lguohan lguohan Awaiting requested review from lguohan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@liuh-80 @qiluo-msft