Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPB][Mellanox]Fixing DPB modes in Mellanox-SN2700-D40C8S8 #8953

Merged
merged 3 commits into from
Oct 13, 2021

Conversation

dgsudharsan
Copy link
Collaborator

@dgsudharsan dgsudharsan commented Oct 12, 2021

Signed-off-by: Sudharsan Dhamal Gopalarathnam [email protected]

Why I did it

Fixing #8938
Fixing 1x10G DPB mode in Mellanox-SN2700-D40C8S8 SKU as it was causing sonic-cfggen to fail.

How I did it

Added correct mode format in hwksu.json in Mellanox-SN2700-D40C8S8 and updated platform.json for the new mode.

How to verify it

Using sonic-cfggen verify it works fine

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@dgsudharsan
Copy link
Collaborator Author

@qiluo-msft Can you please review?

@dgsudharsan
Copy link
Collaborator Author

Request for cherry-pick to 202106

@@ -381,6 +381,7 @@
"lanes": "0,1,2,3",
"breakout_modes": {
"1x100G[50G,40G,25G,10G]": ["etp1"],
"1x10G[100G,50G,40G,25G]": ["etp1"],
Copy link
Collaborator

@qiluo-msft qiluo-msft Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"1x10G[100G,50G,40G,25G]": ["etp1"],
"4x25G[10G]": ["etp1a", "etp1b", "etp1c", "etp1d"],

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Modified accordingly.

qiluo-msft
qiluo-msft previously approved these changes Oct 12, 2021
@qiluo-msft qiluo-msft merged commit 434a641 into sonic-net:master Oct 13, 2021
judyjoseph pushed a commit that referenced this pull request Oct 14, 2021
#### Why I did it
Fixing #8938
Fixing 1x10G DPB mode in Mellanox-SN2700-D40C8S8 SKU as it was causing sonic-cfggen to fail.


#### How I did it
Added correct mode format in hwksu.json in Mellanox-SN2700-D40C8S8  and updated platform.json for the new mode.


#### How to verify it
Using sonic-cfggen verify it works fine
@dgsudharsan dgsudharsan deleted the dbp_2700_fix branch March 9, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants