-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DPB][Mellanox]Fixing DPB modes in Mellanox-SN2700-D40C8S8 #8953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sudharsan Dhamal Gopalarathnam <[email protected]>
@qiluo-msft Can you please review? |
Request for cherry-pick to 202106 |
qiluo-msft
reviewed
Oct 12, 2021
@@ -381,6 +381,7 @@ | |||
"lanes": "0,1,2,3", | |||
"breakout_modes": { | |||
"1x100G[50G,40G,25G,10G]": ["etp1"], | |||
"1x10G[100G,50G,40G,25G]": ["etp1"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
"1x10G[100G,50G,40G,25G]": ["etp1"], | |
"4x25G[10G]": ["etp1a", "etp1b", "etp1c", "etp1d"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Modified accordingly.
qiluo-msft
previously approved these changes
Oct 12, 2021
qiluo-msft
approved these changes
Oct 12, 2021
judyjoseph
pushed a commit
that referenced
this pull request
Oct 14, 2021
#### Why I did it Fixing #8938 Fixing 1x10G DPB mode in Mellanox-SN2700-D40C8S8 SKU as it was causing sonic-cfggen to fail. #### How I did it Added correct mode format in hwksu.json in Mellanox-SN2700-D40C8S8 and updated platform.json for the new mode. #### How to verify it Using sonic-cfggen verify it works fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sudharsan Dhamal Gopalarathnam [email protected]
Why I did it
Fixing #8938
Fixing 1x10G DPB mode in Mellanox-SN2700-D40C8S8 SKU as it was causing sonic-cfggen to fail.
How I did it
Added correct mode format in hwksu.json in Mellanox-SN2700-D40C8S8 and updated platform.json for the new mode.
How to verify it
Using sonic-cfggen verify it works fine
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)