Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Celestica/sonic_platform]: Fixed failed test cases in Haliburton platform testing #8815

Merged
merged 2 commits into from
Oct 8, 2021
Merged

[Celestica/sonic_platform]: Fixed failed test cases in Haliburton platform testing #8815

merged 2 commits into from
Oct 8, 2021

Conversation

mudsut4ke
Copy link
Contributor

@mudsut4ke mudsut4ke commented Sep 22, 2021 •
edited by Blueve
Loading

Why I did it

  • To fixed failed test cases in Haliburton platform testing.

How I did it

  • Define the maximum power drawn by Fan Drawer for fan's API
  • Updated SFP API to the latest specification.
  • Added hwsku.json to skip testing on RJ45 ports.

How to verify it

  • Run platform test on testbed

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@lgtm-com
Copy link

lgtm-com bot commented Sep 22, 2021

This pull request introduces 2 alerts when merging 4d6b1d8 into 4da623c - view on LGTM.com

new alerts:

  • 1 for Unused local variable
  • 1 for Unused import

@mudsut4ke mudsut4ke marked this pull request as ready for review September 23, 2021 01:22
@Blueve Blueve merged commit 800de69 into sonic-net:master Oct 8, 2021
qiluo-msft pushed a commit that referenced this pull request Oct 8, 2021
@qiluo-msft
[Celestica/sonic_platform]: Fixed failed test cases in Haliburton pla…
57df98f 
…tform testing (#8815)

* [device/celestica-e1031]: fix apis follow lastest spec
* [device/celestica-e1031]: fix lgtm (#261)
judyjoseph pushed a commit that referenced this pull request Oct 14, 2021
@judyjoseph
[Celestica/sonic_platform]: Fixed failed test cases in Haliburton pla…
c5c53ac 
…tform testing (#8815)

* [device/celestica-e1031]: fix apis follow lastest spec
* [device/celestica-e1031]: fix lgtm (#261)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blueve Blueve Blueve approved these changes

Assignees
No one assigned
Labels
Included in 202012 Branch Included in 202106 Branch Platform: Celestica Request for 202012 Branch Request for 202106 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mudsut4ke @Blueve @qiluo-msft @judyjoseph