Handle feature flow when state is always_enabled #8811
Conversation
dgsudharsan
changed the title
There was a problem hiding this comment.
@yozhao101 can you review this change? Is 'always_enabled' not allowed by design? If so, can you elaborate the reason?
Ack. Reviewing ... |
The option |
Thanks for confirming! |
|
@yozhao101 please sign off when you are done reviewing. Thanks! |
Approved! |
|
Request for 202106 |
|
@yxieca Can you please add label for 202106? |
Why I did it When feature state is set to always_enabled hostcfgd throws error message Sep 21 22:30:55.135377 r-leopard-32 ERR /hostcfgd: Unexpected state value 'always_enabled' for feature bgp Sep 21 22:30:55.420268 r-leopard-32 ERR /hostcfgd: Unexpected state value 'always_enabled' for feature database Sep 21 22:30:58.672714 r-leopard-32 ERR /hostcfgd: Unexpected state value 'always_enabled' for feature swss This is due to feature == always_enabled not handled properly. How I did it Handled the scenario when feature is always enabled How to verify it Restart hostcfgd with feature state configured as always_enabled and check if there are no errors. Added UT to cover the scenario.
Why I did it
When feature state is set to always_enabled hostcfgd throws error message
Sep 21 22:30:55.135377 r-leopard-32 ERR /hostcfgd: Unexpected state value 'always_enabled' for feature bgp
Sep 21 22:30:55.420268 r-leopard-32 ERR /hostcfgd: Unexpected state value 'always_enabled' for feature database
Sep 21 22:30:58.672714 r-leopard-32 ERR /hostcfgd: Unexpected state value 'always_enabled' for feature swss
This is due to feature == always_enabled not handled properly.
How I did it
Handled the scenario when feature is always enabled
How to verify it
Restart hostcfgd with feature state configured as always_enabled and check if there are no errors.
Added UT to cover the scenario.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)