Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DellEMC: N3248TE Initial platform commit #8809

Merged
merged 3 commits into from
Sep 24, 2021

Conversation

arunlk-dell
Copy link
Contributor

@arunlk-dell arunlk-dell commented Sep 21, 2021

Why I did it

Added support for the device N3248TE

How I did it

Implemented the support for the platform N3248TE

Switch Vendor: DellEMC

  • Switch SKU: N3248TE
  • ASIC Vendor: Broadcom
  • SONiC Image: sonic-broadcom.bin

How to verify it

Verified the show platform commands

n3248te_unit_test_log.txt

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@lgtm-com
Copy link

lgtm-com bot commented Sep 21, 2021

This pull request introduces 61 alerts when merging 6b66dbf1362764a1be032fc4f26f735ae027fe6a into 4049067 - view on LGTM.com

new alerts:

  • 22 for Unused import
  • 17 for Except block handles 'BaseException'
  • 7 for Wrong number of arguments in a class instantiation
  • 5 for Variable defined multiple times
  • 3 for Unused local variable
  • 3 for Result of integer division may be truncated
  • 1 for Module imports itself
  • 1 for Unreachable code
  • 1 for 'import *' may pollute namespace
  • 1 for Wrong name for an argument in a class instantiation

@arunlk-dell arunlk-dell force-pushed the sonic_onboarding_n3248te branch from 6b66dbf to c89b67d Compare September 21, 2021 18:56
@lgtm-com
Copy link

lgtm-com bot commented Sep 21, 2021

This pull request introduces 13 alerts when merging 15620b3 into 34dddb8 - view on LGTM.com

new alerts:

  • 7 for Wrong number of arguments in a class instantiation
  • 3 for Result of integer division may be truncated
  • 1 for Module imports itself
  • 1 for 'import *' may pollute namespace
  • 1 for Wrong name for an argument in a class instantiation

@jeff-yin
Copy link
Collaborator

Requesting @sujinmkang and/or @prgeor to review

@arunlk-dell
Copy link
Contributor Author

@sujinmkang @prgeor
Have addressed the LGTM alerts, the wrong name/number of the argument alerts are due to different platform definitions.
And 'result of integer division may be truncated' alert can be ignored in python3
Can you review and merge the pull request.

@sujinmkang sujinmkang merged commit 8325500 into sonic-net:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants