Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fstrim] delay fstrim timer after sonic.target #8737

Merged
merged 1 commit into from
Sep 13, 2021
Merged

[fstrim] delay fstrim timer after sonic.target #8737

merged 1 commit into from
Sep 13, 2021

Conversation

yxieca
Copy link
Contributor

@yxieca yxieca commented Sep 13, 2021

Why I did it

fstrim has dependency on pmon docker.

How I did it

start fstrim timer after sonic.target.

How to verify it

local test and PR test.

Signed-off-by: Ying Xie [email protected]

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

@yxieca
[202012][fstrim] delay fstrim timer after sonic.target
03e0cd0 
fstrim has dependency on pmon docker.

Signed-off-by: Ying Xie <[email protected]>
@yxieca yxieca requested a review from lguohan as a code owner September 13, 2021 04:33
@yxieca yxieca changed the title [202012][fstrim] delay fstrim timer after sonic.target [fstrim] delay fstrim timer after sonic.target Sep 13, 2021
@bingwang-ms
Copy link
Contributor

The change is verified on my local build, and fstrim.timer is triggered as scheduled.

admin@vlab-01:~$ systemctl status fstrim.timer
● fstrim.timer - Discard unused blocks once a week
     Loaded: loaded (/lib/systemd/system/fstrim.timer; enabled; vendor preset: enabled)
     Active: active (waiting) since Mon 2021-09-13 08:27:06 UTC; 4min 8s ago
    Trigger: Mon 2021-09-13 08:36:44 UTC; 5min left
   Triggers: ● fstrim.service
       Docs: man:fstrim

@yxieca yxieca merged commit 41643a9 into sonic-net:master Sep 13, 2021
@yxieca yxieca deleted the fstrim branch September 13, 2021 14:37
qiluo-msft pushed a commit that referenced this pull request Sep 14, 2021
@yxieca @qiluo-msft
[202012][fstrim] delay fstrim timer after sonic.target (#8737)
e8b8012 
Why I did it
fstrim has dependency on pmon docker.

How I did it
start fstrim timer after sonic.target.

How to verify it
local test and PR test.

Signed-off-by: Ying Xie [email protected]
judyjoseph pushed a commit that referenced this pull request Sep 14, 2021
@yxieca @judyjoseph
[202012][fstrim] delay fstrim timer after sonic.target (#8737)
ff9274d 
Why I did it
fstrim has dependency on pmon docker.

How I did it
start fstrim timer after sonic.target.

How to verify it
local test and PR test.

Signed-off-by: Ying Xie [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bingwang-ms bingwang-ms bingwang-ms approved these changes

@lguohan lguohan Awaiting requested review from lguohan lguohan is a code owner

Assignees
No one assigned
Labels
Included in 202012 Branch Included in 202106 Branch Request for 202012 Branch Request for 202106 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yxieca @bingwang-ms @qiluo-msft @judyjoseph