[CBF] Added configuration templates to generate configs for CBF #8689
Conversation
[build_templates]: Added default configuration file for CBF [rules]: Added loading rule for CBF config Why I did it The CBF default config is required to load default start-up config on CBF capable platforms How I did it Added the default config files among the existing ones, mirroring the QOS implementation How to verify it Deploy SBI on a CBF capable platform(e.g. SODA) Signed-off-by: [email protected]
Cosmin-Jinga-MS
requested review from
lguohan,
qiluo-msft and
xumia
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…e other QoS map tables
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
files/build_templates/cbf_config.j2
Outdated
| @@ -0,0 +1,82 @@ | |||
| { | |||
| "DSCP_TO_TC_MAP": { | |||
There was a problem hiding this comment.
DSCP_TO_TC_MAP is already used by qos_config.j2.
If the intention is to use the same mapping, no need to add here. QoS config generation will create the config for DSCP_TO_TC_MAP. Having in two places will result in race condition where the last config generation will overwrite the DSCP_TO_TC_MAP.
There was a problem hiding this comment.
It's a mistake I've made while updating the dscp mapping to cover all 64 associations. CBF has to have its own separate mapping. I've updated it to DSCP_TO_FC_MAP, as it should be.
|
can you please provide what does FC and CBF stands for ? |
Ok, I think we are referring Forwarding Class and Class Based Forwarding. Bit this create confusion what is the difference between TC and FC ? |
|
@abdosi FC allows traffic engineering as described in https://github.com/Azure/SONiC/pull/796/files while TC allows splitting packets in queues for QoS |
|
@Cosmin-Jinga-MS Going forward we required all configs to have a corresponding yang model. (e.g. PR for QoS #7375 ) Changes look good to me. When do you think you can create a yang model PR for: |
@Cosmin-Jinga-MS Created #9108 Can you assign this to yourself. |
smaheshm
changed the title
| @@ -0,0 +1,82 @@ | |||
| { | |||
| "DSCP_TO_FC_MAP": { | |||
There was a problem hiding this comment.
is the same as DSCP_TO_TC_MAP, or do they need to be same?
There was a problem hiding this comment.
The mappings used for CBF are different from the ones used in QoS. It's intended we have a separate table in this case;
DSCP_TO_TC_MAP for qos
DSCP_TO_FC_MAP for cbf
I don't seem to have the rights to change assignees on that issue. |
[build_templates]: Added default configuration file for CBF
[rules]: Added loading rule for CBF config
Why I did it
The CBF default config is required to load default start-up config on CBF capable platforms
How I did it
Added the default config files among the existing ones, mirroring the QOS implementation
Unit tests are in:
sonic-net/sonic-utilities#1799
How to verify it
Deploy SBI on a CBF capable platform(e.g. SODA)
Description for the changelog
Default CBF config files
Signed-off-by: [email protected]