[Arista] Fix flash size computation for Lodoga #8622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Lodoga platform also matched crow which was hardcoding the flash size to 3700. This change enables autodetect on Clearlake which in turns allows autodetect for Lodoga. The threshold was bumped from 3700 to 4000 because size computation can differ slightly and report slightly above 3700.
|
I think this file can use some comments? It would be confusing to see a change related to 7050qx addresses issues on 7050cx platform. |
yxieca
approved these changes
Aug 30, 2021
qiluo-msft
pushed a commit
that referenced
this pull request
Sep 1, 2021
The Lodoga platform also matched crow which was hardcoding the flash size to 3700. This change enables autodetect on Clearlake which in turns allows autodetect for Lodoga. The threshold was bumped from 3700 to 4000 because size computation can differ slightly and report slightly above 3700.
judyjoseph
pushed a commit
that referenced
this pull request
Sep 2, 2021
The Lodoga platform also matched crow which was hardcoding the flash size to 3700. This change enables autodetect on Clearlake which in turns allows autodetect for Lodoga. The threshold was bumped from 3700 to 4000 because size computation can differ slightly and report slightly above 3700.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
The Lodoga platform also matched crow which was hardcoding the flash
size to 3700.
How I did it
By removing the 3700 hardcoding on crow, this change enables autodetect on Clearlake
which in turns allows autodetect for Lodoga.
The threshold was also bumped from 3700 to 4000 because size computation can
differ slightly and report slightly above 3700.
How to verify it
Verify that
docker_inramis no longer set on/proc/cmdlineWhich release branch to backport (provide reason below if selected)
Description for the changelog
Fix flash size computation in boot0 for Lodoga