Add CLI Support for IPv6 Helpers and DHCPv6 Relay Counters #8593
Conversation
| # DHCPv6 Counter Messages | ||
| messages = ["Solicit", "Advertise", "Request", "Confirm", "Renew", "Rebind", "Reply", "Release", "Decline", "Relay-Forward", "Relay-Reply"] | ||
|
|
||
| class DHCPv6_Counter(object): |
There was a problem hiding this comment.
nit: Please add code comment
|
no unit tests? Is this CLI helpful on T1 switches. Wondering if support for multi ASIC should be added. In future T0 will also have multi ASIC switches. It's good to add support for multi ASIC too. |
@smaheshm Working on adding unit tests! |
dockers/docker-dhcp-relay/cli-plugin-tests/test_show_dhcp6relay_counters.py
Outdated
Show resolved
Hide resolved
|
This pull request introduces 2 alerts when merging ca16c7a into 508b649 - view on LGTM.com new alerts:
|
|
This pull request introduces 3 alerts when merging 9e6e1ed into 34dddb8 - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging 9abff86 into 34dddb8 - view on LGTM.com new alerts:
|
| }, | ||
| }, | ||
| ], | ||
| ] |
There was a problem hiding this comment.
nit: no new line at the end of file.
Why I did it
Support DHCPv6 Relay CLI
How I did it
show dhcp_relay_helpers
show dhcp6relay_counters counts
sonic-clear dhcp6relay_counters
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)