[Mellanox] Read PSU fan max/min speed per PSU #8563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keboliu
approved these changes
Aug 24, 2021
|
/azp run |
|
Commenter does not have sufficient privileges for PR 8563 in repo Azure/sonic-buildimage |
liat-grozovik
approved these changes
Aug 25, 2021
liat-grozovik
requested review from
sujinmkang
and removed request for
sujinmkang
qiluo-msft
pushed a commit
that referenced
this pull request
Aug 27, 2021
#### Why I did it New PSU could install different type of fan, so fan max/min speed should be read per PSU #### How I did it The existing implementation read PSU max/min fan speed from a common file, change it to read from per PSU file #### How to verify it Manual test
4 tasks
|
Hi @qiluo-msft , could you please help cherry-picked this PR to 202106 as well as 201911 branch? Thanks! |
|
@abdosi to cherry-pick to 201911 |
judyjoseph
pushed a commit
that referenced
this pull request
Sep 2, 2021
#### Why I did it New PSU could install different type of fan, so fan max/min speed should be read per PSU #### How I did it The existing implementation read PSU max/min fan speed from a common file, change it to read from per PSU file #### How to verify it Manual test
Junchao-Mellanox
added a commit
to Junchao-Mellanox/sonic-buildimage
that referenced
this pull request
Sep 10, 2021
New PSU could install different type of fan, so fan max/min speed should be read per PSU The existing implementation read PSU max/min fan speed from a common file, change it to read from per PSU file Manual test Conflicts: platform/mellanox/mlnx-platform-api/sonic_platform/fan.py
|
No clean cherry-pick for 201911, created another PR: #8728 |
liat-grozovik
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Sep 12, 2021
Align with PR sonic-net/sonic-buildimage#8563 - How did you do it? Read PSU fan max/min speed per PSU - How did you verify/test it? Manually run test case test_platform_info::test_show_platform_fanstatus_mocked - Any platform specific information? Mellanox
5 tasks
abdosi
pushed a commit
that referenced
this pull request
Sep 13, 2021
vmittal-msft
pushed a commit
to vmittal-msft/sonic-mgmt
that referenced
this pull request
Sep 28, 2021
Align with PR sonic-net/sonic-buildimage#8563 - How did you do it? Read PSU fan max/min speed per PSU - How did you verify/test it? Manually run test case test_platform_info::test_show_platform_fanstatus_mocked - Any platform specific information? Mellanox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
New PSU could install different type of fan, so fan max/min speed should be read per PSU
How I did it
The existing implementation read PSU max/min fan speed from a common file, change it to read from per PSU file
How to verify it
Manual test
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)