-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DellEMC: N3248PXE Initial platform commit #8562
DellEMC: N3248PXE Initial platform commit #8562
Conversation
This pull request introduces 61 alerts when merging 16b7c20 into 5ff87e1 - view on LGTM.com new alerts:
|
This pull request introduces 25 alerts when merging e9d0963 into 086254b - view on LGTM.com new alerts:
|
This pull request introduces 13 alerts when merging a39e2e0 into 086254b - view on LGTM.com new alerts:
|
@sujinmkang @prgeor Can you review? Thanks |
This pull request introduces 13 alerts when merging 4170a69 into 8171bfe - view on LGTM.com new alerts:
|
@arunlk-dell are the remaining LGTM alerts false-positives? |
@jeff-yin Yes, the remaining LGTM alerts are false positive and the wrong name/number of the argument alerts are due to different platform definitions. |
/AzurePipelines run |
Commenter does not have sufficient privileges for PR 8562 in repo Azure/sonic-buildimage |
/azp run |
Commenter does not have sufficient privileges for PR 8562 in repo Azure/sonic-buildimage |
This pull request introduces 13 alerts when merging 42f5b72 into db529af - view on LGTM.com new alerts:
|
@prgeor @sujinmkang... Can you review the changes? Thanks |
@sujinmkang ..... |
This pull request introduces 13 alerts when merging 9e9a265 into 62a1f5e - view on LGTM.com new alerts:
|
Why I did it
Added support for the device N3248PXE
How I did it
Implemented the support for the platform N3248PXE
n3248pxe_unit_test_log.txt
Switch Vendor: DellEMC
* Switch SKU: N3248PXE
* ASIC Vendor: Broadcom
* SONiC Image: sonic-broadcom.bin
How to verify it
Verified the show platform commands
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)