Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DellEMC: N3248PXE Initial platform commit #8562

Merged
merged 6 commits into from
Sep 25, 2021

Conversation

arunlk-dell
Copy link
Contributor

@arunlk-dell arunlk-dell commented Aug 24, 2021

Why I did it

Added support for the device N3248PXE

How I did it

Implemented the support for the platform N3248PXE
n3248pxe_unit_test_log.txt

Switch Vendor: DellEMC
* Switch SKU: N3248PXE
* ASIC Vendor: Broadcom
* SONiC Image: sonic-broadcom.bin

How to verify it

Verified the show platform commands

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@arunlk-dell arunlk-dell requested a review from lguohan as a code owner August 24, 2021 10:13
@lgtm-com
Copy link

lgtm-com bot commented Aug 24, 2021

This pull request introduces 61 alerts when merging 16b7c20 into 5ff87e1 - view on LGTM.com

new alerts:

  • 22 for Unused import
  • 17 for Except block handles 'BaseException'
  • 7 for Wrong number of arguments in a class instantiation
  • 5 for Variable defined multiple times
  • 3 for Unused local variable
  • 3 for Result of integer division may be truncated
  • 1 for Module imports itself
  • 1 for Unreachable code
  • 1 for 'import *' may pollute namespace
  • 1 for Wrong name for an argument in a class instantiation

@lgtm-com
Copy link

lgtm-com bot commented Aug 30, 2021

This pull request introduces 25 alerts when merging e9d0963 into 086254b - view on LGTM.com

new alerts:

  • 7 for Wrong number of arguments in a class instantiation
  • 6 for Unused import
  • 4 for Except block handles 'BaseException'
  • 3 for Result of integer division may be truncated
  • 2 for Variable defined multiple times
  • 1 for Module imports itself
  • 1 for 'import *' may pollute namespace
  • 1 for Wrong name for an argument in a class instantiation

@lgtm-com
Copy link

lgtm-com bot commented Aug 30, 2021

This pull request introduces 13 alerts when merging a39e2e0 into 086254b - view on LGTM.com

new alerts:

  • 7 for Wrong number of arguments in a class instantiation
  • 3 for Result of integer division may be truncated
  • 1 for Module imports itself
  • 1 for 'import *' may pollute namespace
  • 1 for Wrong name for an argument in a class instantiation

@jeff-yin
Copy link
Collaborator

jeff-yin commented Sep 7, 2021

@sujinmkang @prgeor Can you review? Thanks

@lgtm-com
Copy link

lgtm-com bot commented Sep 9, 2021

This pull request introduces 13 alerts when merging 4170a69 into 8171bfe - view on LGTM.com

new alerts:

  • 7 for Wrong number of arguments in a class instantiation
  • 3 for Result of integer division may be truncated
  • 1 for Module imports itself
  • 1 for 'import *' may pollute namespace
  • 1 for Wrong name for an argument in a class instantiation

@jeff-yin
Copy link
Collaborator

@arunlk-dell are the remaining LGTM alerts false-positives?
@lguohan can someone re-trigger the pipeline checks? I don't think we have permissions. I checked a while back and they had been all passing. Not sure what happened.

@arunlk-dell
Copy link
Contributor Author

@jeff-yin Yes, the remaining LGTM alerts are false positive and the wrong name/number of the argument alerts are due to different platform definitions.

@sujinmkang sujinmkang requested a review from prgeor September 13, 2021 15:32
@srideepDell
Copy link
Contributor

srideepDell commented Sep 13, 2021

/AzurePipelines run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 8562 in repo Azure/sonic-buildimage

@arunlk-dell
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 8562 in repo Azure/sonic-buildimage

@lgtm-com
Copy link

lgtm-com bot commented Sep 14, 2021

This pull request introduces 13 alerts when merging 42f5b72 into db529af - view on LGTM.com

new alerts:

  • 7 for Wrong number of arguments in a class instantiation
  • 3 for Result of integer division may be truncated
  • 1 for Module imports itself
  • 1 for 'import *' may pollute namespace
  • 1 for Wrong name for an argument in a class instantiation

@arunlk-dell
Copy link
Contributor Author

arunlk-dell commented Sep 14, 2021

@prgeor @sujinmkang... Can you review the changes? Thanks

sujinmkang
sujinmkang previously approved these changes Sep 16, 2021
@arunlk-dell
Copy link
Contributor Author

@sujinmkang .....
Have addressed the LGTM alerts, the wrong name/number of the argument alerts are due to different platform definitions.
And 'result of integer division may be truncated' alert can be ignored in python3
Can you merge the pull request.

@lgtm-com
Copy link

lgtm-com bot commented Sep 24, 2021

This pull request introduces 13 alerts when merging 9e9a265 into 62a1f5e - view on LGTM.com

new alerts:

  • 7 for Wrong number of arguments in a class instantiation
  • 3 for Result of integer division may be truncated
  • 1 for Module imports itself
  • 1 for 'import *' may pollute namespace
  • 1 for Wrong name for an argument in a class instantiation

@sujinmkang sujinmkang merged commit b0b0ba8 into sonic-net:master Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants