Reapply the fix to address set MTU > 1500 causing portmgrd crash on BRCM platforms #8472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on BRCM platforms
smaheshm
approved these changes
Aug 13, 2021
lguohan
approved these changes
Aug 13, 2021
judyjoseph
pushed a commit
that referenced
this pull request
Aug 25, 2021
…on BRCM platforms (#8472)
judyjoseph
added a commit
to judyjoseph/sonic-buildimage
that referenced
this pull request
Jan 18, 2022
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Feb 15, 2022
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Feb 15, 2022
…on BRCM platforms (sonic-net#8472) Signed-off-by: Zhenggen Xu <[email protected]> RB=2955650 G=lnos-reviewers R=pchaudha,pmao,samaity,stexu,zxu A=
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
This is to address the issue (#8404)
The original fix which was introduced by (#3895) was removed when onboarding BRCM SAI 4.3 (#6526).
At that time this change was removed because there was another way to set the port default MTU to 9100 which caused this change being removed. It was most likely not anticipated that user may need to change the port MTU via CLI at which time this fix when not present will cause portmrgd to crash.
I have create a Case with BRCM (CS00012203989) to ask them to look into this issue to either take this change in and include it to all their future SAI releases and patch their current SAI releases or provide a better alternative to address this issue at which time BRCM team should revert this PR when raising their official fix to address the set interface MTU > 1500 causing portmgrd crash issue.
How I did it
Add back the same change done by (#3895)
How to verify it
Loaded the image and tested with the "sudo config interface mtu Ethernet0 1501" and observe MTU setting go through fine without causing any crash.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Fix set MTU > 1500 on interface causing portmgrd crash on BRCM platforms
A picture of a cute animal (not mandatory but encouraged)