[Makefile]: Remove lockfile before build #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case previous build was forcefully stopped, we need to remove screen lock so that build won't be stuck. Signed-off-by: marian-pritsak <[email protected]>
jleveque
reviewed
Jul 26, 2017
| @@ -7,6 +7,9 @@ SHELL = /bin/bash | |||
| USER := $(shell id -un) | |||
| PWD := $(shell pwd) | |||
|
|
|||
| # Remove lock file in case previous run was forcefully stopped | |||
| $(shell rm -f .screen) | |||
There was a problem hiding this comment.
What process creates this lockfile? Is it screen? If so, screen is not a required build tool, so I'm not sure this should be included in the official Makefile. I've never seen this file get written, but then again, I don't use screen.
There was a problem hiding this comment.
it's internal update_screen.sh
There was a problem hiding this comment.
Ah. I wasn't familiar with your new build output changes.
AidanCopeland
pushed a commit
to Metaswitch/sonic-buildimage
that referenced
this pull request
Apr 14, 2022
Will help using multiple switches in VS with multiple contextes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the previous build was forcefully stopped, we need to remove screen
lock so that build won't be stuck.
Signed-off-by: marian-pritsak [email protected]