Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nokia ixs7215] sfputil support + component tests #8445

Merged
merged 4 commits into from
Aug 13, 2021

Conversation

carl-nokia
Copy link
Contributor

@carl-nokia carl-nokia commented Aug 11, 2021

Why I did it

Deliver sfputil support for sfputil show eeprom and sfputil reset along with some component test case fixes

How I did it

Run sonic-mgmt test_component.py and test_sfputil.py test cases

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@carl-nokia carl-nokia requested a review from lguohan as a code owner August 11, 2021 21:01
@lgtm-com
Copy link

lgtm-com bot commented Aug 11, 2021

This pull request introduces 5 alerts when merging d12f5cd into a53f01d - view on LGTM.com

new alerts:

  • 4 for Unused local variable
  • 1 for Unused import

@carl-nokia
Copy link
Contributor Author

I did that too quickly - let me run thru tests and add the cmdstatus check back - give me two hours

@carl-nokia
Copy link
Contributor Author

O.K. -- this is ready now

@lguohan lguohan merged commit 88cbcb4 into sonic-net:master Aug 13, 2021
lguohan pushed a commit that referenced this pull request Aug 13, 2021
Deliver sfputil support for sfputil show eeprom and sfputil reset along with some component test case fixes

Co-authored-by: Carl Keene <[email protected]>
judyjoseph pushed a commit that referenced this pull request Aug 25, 2021
Deliver sfputil support for sfputil show eeprom and sfputil reset along with some component test case fixes

Co-authored-by: Carl Keene <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants