Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[macsec] Add eapol to copp config #8416

Merged
merged 2 commits into from
Aug 24, 2021
Merged

Conversation

byu343
Copy link
Contributor

@byu343 byu343 commented Aug 10, 2021

Why I did it

This change enables the control packets of MACsec to be processed by CPU.

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@byu343 byu343 requested a review from lguohan as a code owner August 10, 2021 23:01
@lguohan
Copy link
Collaborator

lguohan commented Aug 11, 2021

@prsunny, will this break on platforms that does not support this trap id?

@prsunny
Copy link
Contributor

prsunny commented Aug 11, 2021

@prsunny, will this break on platforms that does not support this trap id?

Yes, it will break. We should have a corresponding feature name and only enable for those platforms that support it. I see that we've a macsec feature. Can the trap be named as "macsec" instead of "eapol"?

@lguohan
Copy link
Collaborator

lguohan commented Aug 11, 2021

@prsunny, how do you suggest to move ahead? how can we enable this trap when macsec feature is enabled?

@lguohan lguohan added the macsec label Aug 13, 2021
@lguohan lguohan merged commit cdfb485 into sonic-net:master Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants