Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aboot] use ram partition for /var/log for devices with 3.7G disks #8400

Merged
merged 7 commits into from
Aug 13, 2021

Conversation

yxieca
Copy link
Contributor

@yxieca yxieca commented Aug 10, 2021

Why I did it

Master/202012 image size grew quite a bit. 3.7G harddrive can no longer hold one image and safely upgrade to another image. Every bit of harddrive space is precious to save now.

Also sh syntax seemingly changed, [ condition ] && action was a legit syntax in 201911 branch but it is an error when condition not met with 202012 or later images. Change the syntax to if statement to avoid the issue.

Signed-off-by: Ying Xie [email protected]

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Master/202012 image size grew quite a bit. 3.7G harddrive can no longer
hold one image and safely upgrade to another image. Every bit of harddrive
space is precious to save now.

Signed-off-by: Ying Xie <[email protected]>
lguohan
lguohan previously approved these changes Aug 10, 2021
Staphylo
Staphylo previously approved these changes Aug 10, 2021
Copy link
Collaborator

@Staphylo Staphylo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks Ying!

yxieca added 2 commits August 11, 2021 21:28
Becasue we are now running union-mount with -e option, any failure would
terminate the execution.

Statement like follow before -e would be fine, but with -e, when condition
fails, it will terminate the execution.

[ condition ] && command

Signed-off-by: Ying Xie <[email protected]>
@yxieca yxieca dismissed stale reviews from Staphylo and lguohan via 36fe7e5 August 11, 2021 21:31
@yxieca yxieca requested a review from saiarcot895 August 11, 2021 21:46
Staphylo
Staphylo previously approved these changes Aug 11, 2021
Copy link
Collaborator

@Staphylo Staphylo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ying for figuring that one out!
The set -e in the shebang was pretty tricky indeed.

files/initramfs-tools/union-mount.j2 Show resolved Hide resolved
files/initramfs-tools/union-mount.j2 Show resolved Hide resolved
saiarcot895
saiarcot895 previously approved these changes Aug 11, 2021
@yxieca yxieca dismissed stale reviews from saiarcot895 and Staphylo via ce7b1f0 August 11, 2021 22:27
Staphylo
Staphylo previously approved these changes Aug 11, 2021
Copy link
Collaborator

@Staphylo Staphylo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yxieca yxieca merged commit 71e8b0c into sonic-net:master Aug 13, 2021
@yxieca yxieca deleted the ramlog branch August 13, 2021 16:01
lguohan pushed a commit that referenced this pull request Aug 15, 2021
…8400)

Master/202012 image size grew quite a bit. 3.7G harddrive can no longer hold one image and safely upgrade to another image. Every bit of harddrive space is precious to save now.

Also sh syntax seemingly changed, [ condition ] && action was a legit syntax in 201911 branch but it is an error when condition not met with 202012 or later images. Change the syntax to if statement to avoid the issue.

Signed-off-by: Ying Xie [email protected]
judyjoseph pushed a commit that referenced this pull request Aug 25, 2021
…8400)

Master/202012 image size grew quite a bit. 3.7G harddrive can no longer hold one image and safely upgrade to another image. Every bit of harddrive space is precious to save now.

Also sh syntax seemingly changed, [ condition ] && action was a legit syntax in 201911 branch but it is an error when condition not met with 202012 or later images. Change the syntax to if statement to avoid the issue.

Signed-off-by: Ying Xie [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants