Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nokia] Add hwsku.json for the Nokia-7215 #8372

Merged
merged 3 commits into from
Aug 12, 2021
Merged

Conversation

carl-nokia
Copy link
Contributor

Why I did it

hwsku.json port_type attribute is the preferred method for test to differentiate copper vs sfp+ for Nokia-7215.

How I did it

added PR 8370 on which this PR depends first - then added hwsku.json file according to platform specification.

How to verify it

Which release branch to backport (provide reason below if selected)

Depends on PR 8370

Needed for Nokia 7215 test pass

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@carl-nokia carl-nokia requested a review from lguohan as a code owner August 7, 2021 20:08
@carl-nokia carl-nokia changed the title Addhwsku add hwsku.json for the Nokia-7215 Aug 7, 2021
@carl-nokia carl-nokia changed the title add hwsku.json for the Nokia-7215 [Nokia] Add hwsku.json for the Nokia-7215 Aug 7, 2021
yxieca
yxieca previously approved these changes Aug 7, 2021
@dflynn-Nokia
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 8372 in repo Azure/sonic-buildimage

@dflynn-Nokia
Copy link
Contributor

/AzurePipelines run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 8372 in repo Azure/sonic-buildimage

@Blueve
Copy link
Contributor

Blueve commented Aug 11, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@Blueve Blueve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is anywhere consume this attribute? Is yes, you might need update the hwsku_json_checker in your PR as well.

Ah.. you did this on #8370 please ignore.

@Blueve Blueve merged commit 28dca68 into sonic-net:master Aug 12, 2021
lguohan pushed a commit that referenced this pull request Aug 12, 2021
* add hwsku.json for the Nokia-7215
* added required default_brkout_mode to hwsku as its not optional
* remove tabs from the file so spacing consistent

Co-authored-by: Carl Keene <[email protected]>
judyjoseph pushed a commit that referenced this pull request Aug 25, 2021
* add hwsku.json for the Nokia-7215
* added required default_brkout_mode to hwsku as its not optional
* remove tabs from the file so spacing consistent

Co-authored-by: Carl Keene <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants