-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nokia] Add hwsku.json for the Nokia-7215 #8372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carl-nokia
changed the title
add hwsku.json for the Nokia-7215
[Nokia] Add hwsku.json for the Nokia-7215
Aug 7, 2021
yxieca
previously approved these changes
Aug 7, 2021
/azp run |
Commenter does not have sufficient privileges for PR 8372 in repo Azure/sonic-buildimage |
/AzurePipelines run |
Commenter does not have sufficient privileges for PR 8372 in repo Azure/sonic-buildimage |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Blueve
suggested changes
Aug 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is anywhere consume this attribute? Is yes, you might need update the hwsku_json_checker in your PR as well.
Ah.. you did this on #8370 please ignore.
Blueve
approved these changes
Aug 11, 2021
yxieca
approved these changes
Aug 12, 2021
lguohan
pushed a commit
that referenced
this pull request
Aug 12, 2021
* add hwsku.json for the Nokia-7215 * added required default_brkout_mode to hwsku as its not optional * remove tabs from the file so spacing consistent Co-authored-by: Carl Keene <[email protected]>
judyjoseph
pushed a commit
that referenced
this pull request
Aug 25, 2021
* add hwsku.json for the Nokia-7215 * added required default_brkout_mode to hwsku as its not optional * remove tabs from the file so spacing consistent Co-authored-by: Carl Keene <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
hwsku.json port_type attribute is the preferred method for test to differentiate copper vs sfp+ for Nokia-7215.
How I did it
added PR 8370 on which this PR depends first - then added hwsku.json file according to platform specification.
How to verify it
Which release branch to backport (provide reason below if selected)
Depends on PR 8370
Needed for Nokia 7215 test pass
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)