Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating sonic-swss submodule #8340

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Conversation

Praveen-Brcm
Copy link
Contributor

@Praveen-Brcm Praveen-Brcm commented Aug 4, 2021

Updating sonic-swss submodule to pick PR 1331 changes

Why I did it

To pull the PR 1331 changes

List of changes:

commit 7aca82d
Author: Praveen-Brcm [email protected]
Date: Tue Aug 3 17:29:56 2021 -0700
Mclag enhacements support code changes. (#1331)

commit 72a72f8
Author: Ann Pokora [email protected]
Date: Mon Aug 2 21:30:07 2021 -0400
[crm] Fix for Issue #8036 (#1829)
*Added more appropriate log message for CRM queries of MPLS_INSEG and MPLS_NEXTHOP resources when platform does not support these resource types._

@Praveen-Brcm
Copy link
Contributor Author

@gechiang can you please help review and merge to track the Sonic-swss submodule update. Thanks - Praveen

@arlakshm
Copy link
Contributor

arlakshm commented Aug 4, 2021

@Praveen-Brcm, can please update the PR description with list of commits in this submodule update has. Thanks

@gechiang gechiang requested a review from prsunny August 4, 2021 19:27
@Praveen-Brcm
Copy link
Contributor Author

I

@Praveen-Brcm, can please update the PR description with list of commits in this submodule update has. Thanks

@arlakshm : 2 commits part of submodule update, pls find below commit details.

_commit 7aca82d (HEAD -> master, origin/master, origin/HEAD)

Author: Praveen-Brcm [email protected]
Date: Tue Aug 3 17:29:56 2021 -0700
Mclag enhacements support code changes. (#1331)
commit 72a72f8
Author: Ann Pokora [email protected]
Date: Mon Aug 2 21:30:07 2021 -0400

[crm] Fix for Issue Azure/sonic-buildimage#8036 (#1829)
*Added more appropriate log message for CRM queries of MPLS_INSEG and MPLS_NEXTHOP resources when platform does not support these resource types._

@gechiang
Copy link
Collaborator

gechiang commented Aug 4, 2021

I

@Praveen-Brcm, can please update the PR description with list of commits in this submodule update has. Thanks

@arlakshm : 2 commits part of submodule update, pls find below commit details.

_commit 7aca82d (HEAD -> master, origin/master, origin/HEAD)

Author: Praveen-Brcm [email protected]
Date: Tue Aug 3 17:29:56 2021 -0700
Mclag enhacements support code changes. (#1331)
commit 72a72f8
Author: Ann Pokora [email protected]
Date: Mon Aug 2 21:30:07 2021 -0400

[crm] Fix for Issue Azure/sonic-buildimage#8036 (#1829)
*Added more appropriate log message for CRM queries of MPLS_INSEG and MPLS_NEXTHOP resources when platform does not support these resource types._

can you move the content as part of your original description of this PR instead of just as a comment which can get overlooked...
Thanks!

@Praveen-Brcm
Copy link
Contributor Author

I

@Praveen-Brcm, can please update the PR description with list of commits in this submodule update has. Thanks

@arlakshm : 2 commits part of submodule update, pls find below commit details.

_commit 7aca82d (HEAD -> master, origin/master, origin/HEAD)

Author: Praveen-Brcm [email protected]
Date: Tue Aug 3 17:29:56 2021 -0700
Mclag enhacements support code changes. (#1331)
commit 72a72f8
Author: Ann Pokora [email protected]
Date: Mon Aug 2 21:30:07 2021 -0400

[crm] Fix for Issue Azure/sonic-buildimage#8036 (#1829)
*Added more appropriate log message for CRM queries of MPLS_INSEG and MPLS_NEXTHOP resources when platform does not support these resource types._

can you move the content as part of your original description of this PR instead of just as a comment which can get overlooked...
Thanks!
@gechiang : Thanks Updated the description with list of commits.

@Praveen-Brcm
Copy link
Contributor Author

@gechiang , @arlakshm : The tests are passing can you please help merge.?

@gechiang gechiang merged commit 1bc3fdb into sonic-net:master Aug 5, 2021
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
Mclag enhacements support code changes. (sonic-net#1331)
[crm] Fix for Issue sonic-net#8036 (sonic-net#1829)
@liat-grozovik
Copy link
Collaborator

@gechiang submodule should not be cherry picked. the PRs itself should. please review if the label is set on the PRs you wish to have in 202106.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants