[bgpcfgd][voq] Fix for unit test failure in bgpcfgd config for voq switch #8278
Conversation
The unit test failure was due to missing bgp graceful restart select defer time configuration in voq_chassis.conf. Modified sample output data file voq_chassis.conf to include this configuration. Signed-off-by: vedganes <[email protected]>
vganesan-nokia
force-pushed
the
bgpcfgd-blderr-fix1
branch
from
f024d00 to
9f91348
Compare
|
@vganesan-nokia can you please clarify how #8049 got merged when it can cause build failure ? |
I can think of the following reasoning: Even though the PR #7533 that introduced bgp graceful-restart select time configuration in file dockers/docker-fpm-frr/frr/bgpd/bgpd.main.conf.j2 got merged before #8049 merge, PR #8049's pipeline checks have all passed before that. Since the changes from PR #7533 and changes from PR #8049 for this file did not generate any conflict, git did not notify us of conflict either during merging (or before merging) and merging was successful. The build failure was due to ut failure in sonic-bgpcfgd. The ut failure was because of voq_chassis.conf which is a new file and is pre-pr #7533 sample output (i.e the file voq_chassis.conf did not have the graceful restart select timer config), After merging #8049, during Azure build UT failed while comparing generated file (based on post-pr #7533, which has graceful restart select timer configuration) with pre-pr #7533 sample output file (which did not have the graceful restart select timer config) |
…sonic-net#8278) The unit test failure was due to missing bgp graceful restart select defer time configuration in voq_chassis.conf. Modified sample output data file voq_chassis.conf to include this configuration. Signed-off-by: vedganes <[email protected]>
…#8278) The unit test failure was due to missing bgp graceful restart select defer time configuration in voq_chassis.conf. Modified sample output data file voq_chassis.conf to include this configuration. Signed-off-by: vedganes <[email protected]>
Why I did it
To fix Azure pipeline failure due to unit test failure in sonic-bgpcfgd submodule.
How I did it
The unit test failure was due to missing bgp graceful restart select defer time configuration in voq_chassis.conf. Modified sample output data file voq_chassis.conf to include this configuration.
How to verify it
Which release branch to backport (provide reason below if selected)
N/A
Description for the changelog
Fix for unit test failure in bgpcfgd for voq switch