Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[201911] Adding SKU Mellanox-SN3800-D100C12S2 #7972

Merged

Conversation

madhanmellanox
Copy link
Contributor

Why I did it

To create a new SKU Mellanox-SN3800-D100C12S2

How I did it

I arrived at the SKU configuration values based on the following SKU template, Port mapping and number of uplinks and downlinks.

SKU template:
Port configuration
• Breakout mode for each port - Defined in port mapping
• Speed of the port Defined in Port mapping
• Auto-negotiation enable/disable No setting required
• FEC mode No setting required
• Type of transceiver used Not needed
Buffer configuration
• Shared headroom enable
• If shared headroom enabled what is the over-subscription ratio as in SN3800
• Dynamic Buffer disable
• In static buffer scenario how many uplinks and downlinks? as in SN3800
• 2km cable support required? no
Switch configuration
• Warmboot enabled? yes
• Should warmboot be added to SAI profile when enabled? yes
• Is VxLAN source port range set? yes
• Should Vxlan source port range be added to SAI profile when set. as in SN3800
• Is Static Policy Based Hashing enabled? no

Port Mapping
etp1 to etp36 split into 50G
etp37 and etp40 is 10G
etp38 and etp39 splint into 50G
etp41 to etp52 split into 50G
etp53 to etp64 is 100G

Number of Uplinks / Downlinks:
TO topology: 12 100G uplinks and rest all downlinks.
T1 topology: (SKU will not be used in T1 topology), so same 12 100G uplinks and rest all downlinks is used to arrive at buffer config values.

How to verify it

Build the image, install it on the 3800 switch and set the SKU and verify the ports come up with proper speeds.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

Changes are in sonic-buildimage/device/mellanox/x86_64-mlnx_msn3800-r0/Mellanox-SN3800-D100C12S2/ folder.

A picture of a cute animal (not mandatory but encouraged)

@@ -0,0 +1,2 @@
SAI_INIT_CONFIG_FILE=/usr/share/sonic/hwsku/sai_3800_2x10g_28x50g_48x100g.xml
Copy link
Contributor

@prsunny prsunny Jun 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is the xml file name different from sai_3800_2x10g_100x50g_12x100g.xml?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this change tested?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, this has to be fixed. I will fix it.

@prsunny
Copy link
Contributor

prsunny commented Jun 24, 2021

Can someone from NVDIA team sign-off? @liat-grozovik , @volodymyrsamotiy .

Ethernet144 144,145,146,147 etp37 37 10000
Ethernet148 148,149 etp38a 38 50000
Ethernet150 150,151 etp38b 38 50000
Ethernet152 152,153 etp39a 38 50000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this 39 (index) ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it is. Sorry, I will fix it.

@@ -0,0 +1 @@
../../x86_64-mlnx_msn2700-r0/ACS-MSN2700/qos.json.j2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pg_profile is pointing to ../Mellanox-SN3800-D112C8/pg_profile_lookup.ini. Can you confirm if these soft-links are correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes I verified it on the workspace, the symbolic link is there. I also verified the pg_profile_lookup.ini file is viewable on the switch as well.

Copy link
Contributor

@alexrallen alexrallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve with exception of 10G ports needing validation.

@prsunny
Copy link
Contributor

prsunny commented Jun 28, 2021

@liat-grozovik , @volodymyrsamotiy , @dgsudharsan , can we merge this?

@prsunny prsunny merged commit 2bec300 into sonic-net:201911 Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants