Support to build armhf/arm64 platforms on arm based system #7731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
May 27, 2021
Makefile.work
Outdated
| COMPILE_HOST_ARCH := armhf | ||
| else | ||
| COMPILE_HOST_ARCH := amd64 | ||
| endif | ||
|
|
||
| COMPILE_HOST_ARCHS := $(COMPILE_HOST_ARCH) $(HOST_ARCHS) |
There was a problem hiding this comment.
I search the repo and could not found HOST_ARCHS
There was a problem hiding this comment.
Yes, it is not defined, normally, we are not necessary to define it, the default value is empty.
If we want to support build armhf on arm64, we can set HOST_ARCHS=armhf, it means that the architecture armhf is supported on arm64, although it does not match with "uname -m".
There was a problem hiding this comment.
OK, this paragraph is good code comment, could you add it? Otherwise user could not easily figure out this hidden feature.
qiluo-msft
reviewed
May 27, 2021
qiluo-msft
reviewed
May 27, 2021
Makefile.work
Outdated
| @@ -111,18 +113,13 @@ ifeq ($(ENABLE_DOCKER_BASE_PULL),) | |||
| override ENABLE_DOCKER_BASE_PULL = n | |||
| endif | |||
|
|
|||
| ifeq ($(CONFIGURED_ARCH),amd64) | |||
| ifneq (,$(filter $(CONFIGURED_ARCH),amd64 $(COMPILE_HOST_ARCHS))) | |||
There was a problem hiding this comment.
Could you add some comment for complex condition check? #Closed
qiluo-msft
reviewed
May 27, 2021
dockers/docker-base/Dockerfile.j2
Outdated
| @@ -1,6 +1,6 @@ | |||
| {% if CONFIGURED_ARCH == "armhf" and MULTIARCH_QEMU_ENVIRON == "y" %} | |||
There was a problem hiding this comment.
For armhf, we can always use multiarch/debian-debootstrap:armhf-jessie, it should not be relative to MULTIARCH_QEMU_ENVIRON yes or not.
Maybe we can simply use multiarch/debian-debootstrap:{% CONFIGURED_ARCH %}-jessie
Example:
docker run -it --rm multiarch/debian-debootstrap:amd64-buster uname -m
x86_64
|
what about building arm64 on armhf? that is probably not supported, correct? |
lguohan
previously approved these changes
Aug 3, 2021
It is not supported, it needs to use only qemu vm to support. |
|
@qiluo-msft , I do an improvement to detect the docker environment in the build time to decide whether the qemu simulator needed. When the docker arch of the build environment is the same as the build target, then no simulator required. |
lguohan
approved these changes
Aug 11, 2021
qiluo-msft
approved these changes
Aug 12, 2021
xumia
added a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Aug 13, 2021
…#7731) Why I did it Support to build armhf/arm64 platforms on arm based system without qemu simulator. When building the armhf/arm64 on arm based system, it is not necessary to use qemu simulator. How I did it Build armhf on armhf system, or build arm64 on arm64 system, by default, qemu simulator will not be used. When building armhf on arm64, and you have enabled armhf docker, then it will build images without simulator automatically. It is based how the docker service is run. Docker base image change: For amd64, change from debian:to amd64/debian: For arm64, change from multiarch/debian-debootstrap:arm64- to arm64v8/debian: For armhf, change from multiarch/debian-debootstrap:armhf- to arm32v7/debian: See https://github.com/docker-library/official-images#architectures-other-than-amd64 The mapping relations: arm32v6 --- armel arm32v7 --- armhf arm64v8 --- arm64 Docker image armhf deprecated info: https://hub.docker.com/r/armhf/debian, using arm32v7 instead.
xumia
added a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Aug 13, 2021
…#7731) Why I did it Support to build armhf/arm64 platforms on arm based system without qemu simulator. When building the armhf/arm64 on arm based system, it is not necessary to use qemu simulator. How I did it Build armhf on armhf system, or build arm64 on arm64 system, by default, qemu simulator will not be used. When building armhf on arm64, and you have enabled armhf docker, then it will build images without simulator automatically. It is based how the docker service is run. Docker base image change: For amd64, change from debian:to amd64/debian: For arm64, change from multiarch/debian-debootstrap:arm64- to arm64v8/debian: For armhf, change from multiarch/debian-debootstrap:armhf- to arm32v7/debian: See https://github.com/docker-library/official-images#architectures-other-than-amd64 The mapping relations: arm32v6 --- armel arm32v7 --- armhf arm64v8 --- arm64 Docker image armhf deprecated info: https://hub.docker.com/r/armhf/debian, using arm32v7 instead.
xumia
added a commit
that referenced
this pull request
Aug 13, 2021
…8458) Why I did it Support to build armhf/arm64 platforms on arm based system without qemu simulator. When building the armhf/arm64 on arm based system, it is not necessary to use qemu simulator. How I did it Build armhf on armhf system, or build arm64 on arm64 system, by default, qemu simulator will not be used. When building armhf on arm64, and you have enabled armhf docker, then it will build images without simulator automatically. It is based how the docker service is run. Docker base image change: For amd64, change from debian:to amd64/debian: For arm64, change from multiarch/debian-debootstrap:arm64- to arm64v8/debian: For armhf, change from multiarch/debian-debootstrap:armhf- to arm32v7/debian: See https://github.com/docker-library/official-images#architectures-other-than-amd64 The mapping relations: arm32v6 --- armel arm32v7 --- armhf arm64v8 --- arm64 Docker image armhf deprecated info: https://hub.docker.com/r/armhf/debian, using arm32v7 instead.
xumia
added a commit
to xumia/sonic-buildimage-1
that referenced
this pull request
Apr 14, 2022
…#7731) Why I did it Support to build armhf/arm64 platforms on arm based system without qemu simulator. When building the armhf/arm64 on arm based system, it is not necessary to use qemu simulator. How I did it Build armhf on armhf system, or build arm64 on arm64 system, by default, qemu simulator will not be used. When building armhf on arm64, and you have enabled armhf docker, then it will build images without simulator automatically. It is based how the docker service is run. Docker base image change: For amd64, change from debian:to amd64/debian: For arm64, change from multiarch/debian-debootstrap:arm64- to arm64v8/debian: For armhf, change from multiarch/debian-debootstrap:armhf- to arm32v7/debian: See https://github.com/docker-library/official-images#architectures-other-than-amd64 The mapping relations: arm32v6 --- armel arm32v7 --- armhf arm64v8 --- arm64 Docker image armhf deprecated info: https://hub.docker.com/r/armhf/debian, using arm32v7 instead.
6 tasks
xumia
added a commit
that referenced
this pull request
Apr 15, 2022
…10577) Why I did it Support to build armhf/arm64 platforms on arm based system without qemu simulator. When building the armhf/arm64 on arm based system, it is not necessary to use qemu simulator. How I did it Build armhf on armhf system, or build arm64 on arm64 system, by default, qemu simulator will not be used. When building armhf on arm64, and you have enabled armhf docker, then it will build images without simulator automatically. It is based how the docker service is run. Docker base image change: For amd64, change from debian:to amd64/debian: For arm64, change from multiarch/debian-debootstrap:arm64- to arm64v8/debian: For armhf, change from multiarch/debian-debootstrap:armhf- to arm32v7/debian: See https://github.com/docker-library/official-images#architectures-other-than-amd64 The mapping relations: arm32v6 --- armel arm32v7 --- armhf arm64v8 --- arm64 Docker image armhf deprecated info: https://hub.docker.com/r/armhf/debian, using arm32v7 instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Support to build armhf/arm64 platforms on arm based system without qemu simulator.
When building the armhf/arm64 on arm based system, it is not necessary to use qemu simulator.
How I did it
Build armhf on armhf system, or build arm64 on arm64 system, by default, qemu simulator will not be used.
When building armhf on arm64, and you have enabled armhf docker, then it will build images without simulator automatically. It is based how the docker service is run.
Docker base image change:
For amd64, change from debian:to amd64/debian:
For arm64, change from multiarch/debian-debootstrap:arm64- to arm64v8/debian:
For armhf, change from multiarch/debian-debootstrap:armhf- to arm32v7/debian:
See https://github.com/docker-library/official-images#architectures-other-than-amd64
The mapping relations:
arm32v6 --- armel
arm32v7 --- armhf
arm64v8 --- arm64
Docker image armhf deprecated info: https://hub.docker.com/r/armhf/debian, using arm32v7 instead.
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)