Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[201911][docker-teamd]: Increase teammgrd timeout to allow graceful shutdown #7662

Merged
merged 1 commit into from
May 27, 2021

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented May 20, 2021

Signed-off-by: Nazarii Hnydyn [email protected]

Adding a missing part of #6537

Resolves #7591

Why I did it

  • To fix LAG IP configuration race

How I did it

  • Extended timeout for teammgrd

How to verify it

  1. Add >80 router LAGs
  2. Do config reload

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

  • N/A

A picture of a cute animal (not mandatory but encouraged)

      .---.        .-----------
     /     \  __  /    ------
    / /     \(  )/    -----
   //////   ' \/ `   ---
  //// / // :    : ---
 // /   /  /`    '--
//          //..\\
       ====UU====UU====
           '//||\\`
             ''``

@nazariig nazariig changed the title [docker-teamd]: Increase teammgrd timeout to allow graceful shutdown [201911][docker-teamd]: Increase teammgrd timeout to allow graceful shutdown May 20, 2021
@liat-grozovik
Copy link
Collaborator

@nazariig can you please explain why this is needed and what is the system behaviour if it is not available?
@lguohan is it by purpose that this PR has no build check?

@lguohan
Copy link
Collaborator

lguohan commented May 20, 2021

i am not aware of. @xumia, @liushilongbuaa , can you check why pr build is not triggered?

@xumia
Copy link
Collaborator

xumia commented May 21, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@prsunny
Copy link
Contributor

prsunny commented May 27, 2021

Discussed with Judy, and request to add teamsyncd changes as a later PR.

@prsunny prsunny merged commit a388b71 into sonic-net:201911 May 27, 2021
bingwang-ms pushed a commit to bingwang-ms/sonic-buildimage that referenced this pull request Jun 10, 2021
lguohan pushed a commit that referenced this pull request Jun 10, 2021
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request Jun 16, 2021
liat-grozovik pushed a commit that referenced this pull request Jul 7, 2021
…#7662) (#8045)

NOTE: This is cherry-pick from 1911/2012 to master.

- Why I did it
To fix LAG IP configuration race

- How I did it
Extended timeout for teammgrd

- How to verify it
Add >80 router LAGs. Do config reload

Signed-off-by: Nazarii Hnydyn <[email protected]>
judyjoseph pushed a commit that referenced this pull request Jul 13, 2021
…#7662) (#8045)

NOTE: This is cherry-pick from 1911/2012 to master.

- Why I did it
To fix LAG IP configuration race

- How I did it
Extended timeout for teammgrd

- How to verify it
Add >80 router LAGs. Do config reload

Signed-off-by: Nazarii Hnydyn <[email protected]>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
…sonic-net#7662) (sonic-net#8045)

NOTE: This is cherry-pick from 1911/2012 to master.

- Why I did it
To fix LAG IP configuration race

- How I did it
Extended timeout for teammgrd

- How to verify it
Add >80 router LAGs. Do config reload

Signed-off-by: Nazarii Hnydyn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants