Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Accton] Support ACBEL FSF0xx PSU #7615

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

seanwu-ec
Copy link
Contributor

@seanwu-ec seanwu-ec commented May 14, 2021

Why I did it

We are gonna replace our current PSU with ACBEL FSF0xx ones.

How I did it

Started from accton_as7716_32x_psu.c, which is already capable to work with multiple PSUs. It's easy to add an additional one.
Then I just clone the required parts from accton_as7716_32x_psu.c to other accton models.

How to verify it

  1. cat sysfs attrs and see if they work well.
admin@sonic:/sys/bus/i2c/devices$ /tmp/dump_files.sh 13-0053/psu*
=== 13-0053/psu_model_name ===
FSF019-611
=== 13-0053/psu_power_good ===
1
=== 13-0053/psu_present ===
1

admin@sonic:/sys/bus/i2c/devices$ /tmp/dump_files.sh 13-005b/psu*
=== 13-005b/psu_fan1_duty_cycle_percentage ===
0
=== 13-005b/psu_fan1_fault ===
0
=== 13-005b/psu_fan1_speed_rpm ===
6144
=== 13-005b/psu_fan_dir ===
F2B
=== 13-005b/psu_i_out ===
9500
=== 13-005b/psu_mfr_id ===
	ACBEL   
=== 13-005b/psu_mfr_iin_max ===
10000
=== 13-005b/psu_mfr_iout_max ===
54000
=== 13-005b/psu_mfr_model ===
FSF019  
=== 13-005b/psu_mfr_pin_max ===
650000
=== 13-005b/psu_mfr_pout_max ===
650000
=== 13-005b/psu_mfr_revision ===
0
=== 13-005b/psu_mfr_vin_max ===
264000
=== 13-005b/psu_mfr_vin_min ===
90000
=== 13-005b/psu_mfr_vout_max ===
12593
=== 13-005b/psu_mfr_vout_min ===
11390
=== 13-005b/psu_over_temp ===
0
=== 13-005b/psu_pmbus_revision ===
34
=== 13-005b/psu_p_out ===
121000
=== 13-005b/psu_power_good ===
1
=== 13-005b/psu_power_on ===
1
=== 13-005b/psu_temp1_input ===
35000
=== 13-005b/psu_temp_fault ===
0
=== 13-005b/psu_v_out ===
12125
  1. Checked if the output of show platform psustatus is as we expected. (Only )
admin@sonic:/sys/bus/i2c/devices$ show platform psustatus 
PSU    Model    Serial    Voltage (V)    Current (A)    Power (W)    Status       LED
-----  -------  --------  -------------  -------------  -----------  -----------  -----
PSU 1                                                                NOT PRESENT
PSU 2                                                                OK

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

[Accton] Support ACBEL FSF019, FSF045 PSU

Models: as7326_56x, as7712_32x, as7716_32x, as7726_32x

Signed-off-by: Sean Wu [email protected]

A picture of a cute animal (not mandatory but encouraged)

@seanwu-ec seanwu-ec marked this pull request as ready for review May 14, 2021 09:53
@seanwu-ec seanwu-ec requested a review from lguohan as a code owner May 14, 2021 09:53
Models: as7326_56x, as7712_32x, as7716_32x, as7726_32x

Signed-off-by: Sean Wu <[email protected]>
@seanwu-ec
Copy link
Contributor Author

Hi @lguohan ,
I have checked the raw log (https://dev.azure.com/mssonic/be1b070f-be15-4154-aade-b1d3bfb17054/_apis/build/builds/17834/logs/70) and tried to confirm whether my modification causes the kvmtest-t0 fail.

FAILED: dut:Longest downtime period must be less then 200 seconds. It was 0:03:52.873373",

But my modifications are only related to sysfs attr, they have nothing to do with bootup/shutdown, it shouldn't be able to affect this test...
Any suggestion? Thanks.

@seanwu-ec seanwu-ec changed the title [Accton] Support ACBEL FSF019 PSU [Accton] Support ACBEL FSF0xx PSU Jul 13, 2021
@seanwu-ec
Copy link
Contributor Author

seanwu-ec commented Sep 22, 2021

Hi @lguohan, would you mind give me a hint about how to get my PRs reviewed and merged? Anything would do. Thanks.

* Model: AS7726-32X, AS7326-56X

Signed-off-by: Sean Wu <[email protected]>
@seanwu-ec
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@seanwu-ec
Copy link
Contributor Author

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 7615 in repo Azure/sonic-buildimage

@seanwu-ec
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants