-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sonic-app-ext] support app extensions installation during build #7593
[sonic-app-ext] support app extensions installation during build #7593
Conversation
Signed-off-by: Stepan Blyschak <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. just a minor comment
files/scripts/swss.sh
Outdated
@@ -1,8 +1,17 @@ | |||
#!/bin/bash | |||
|
|||
DEPENDENT="radv dhcp_relay" | |||
DEPENDENT="radv" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: dhcp_relay should be still in the DEPENDENT
. It should be remove by the DHCP PR #6531
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stepanblyschak , can you please resolve this nit comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is already resolved, forgot to put a comment about it.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@stepanblyschak please handle conflicts and rerun tests. |
…xt-build Signed-off-by: Stepan Blyschak <[email protected]>
0652d46
to
287a7e1
Compare
Signed-off-by: Stepan Blyschak <[email protected]>
287a7e1
to
abe88c0
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
EDIT: fixed ptf docker build in latest commit. |
…ic-utilities for dockers that dont need it Signed-off-by: Stepan Blyschak <[email protected]>
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Same build error observed in different PR - https://dev.azure.com/mssonic/build/_build/results?buildId=19675&view=logs&j=88ce9a53-729c-5fa9-7b6e-3d98f2488e3f&t=8d99be27-49d0-54d0-99b1-cfc0d47f0318 |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@stepanblyschak can you please handle the new conflict? |
@renukamanavalan and @tahmed-dev can you please approve? |
@tahmed-dev can you please approve? |
…ic-net#7593) Signed-off-by: Stepan Blyschak [email protected] Why I did it To support building DHCP relay as extension and installing it during build time. How I did it Created infrastructure. Users need to define their packages in rules/sonic-packages.mk How to verify it Together with sonic-net#6531
Signed-off-by: Stepan Blyschak [email protected]
Why I did it
To support building DHCP relay as extension and installing it during build time.
How I did it
Created infrastructure. Users need to define their packages in rules/sonic-packages.mk
How to verify it
Together with #6531
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)