-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] [202012] Enhance the platform.json with adding more platform device facts. #7496
Merged
liat-grozovik
merged 3 commits into
sonic-net:202012
from
keboliu:202012-amend_platform_json
May 9, 2021
Merged
[Mellanox] [202012] Enhance the platform.json with adding more platform device facts. #7496
liat-grozovik
merged 3 commits into
sonic-net:202012
from
keboliu:202012-amend_platform_json
May 9, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kebo Liu <[email protected]>
Signed-off-by: Kebo Liu <[email protected]>
liat-grozovik
approved these changes
May 2, 2021
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
@jleveque please note that this PR is against 202012 and cannot be cherry picked from master as master has interfaces already included for dynamic port breakout which should not be taken to 202012. |
/azp run |
jleveque
approved these changes
May 3, 2021
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi, @daall would you please help to merge to 202012? |
liat-grozovik
approved these changes
May 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Current platform.json lacks some peripheral device related facts, like chassis/fan/pasu/drawer/thermal/components names, numbers, etc.
How I did it
Add platform device facts to the platform.json file
How to verify it
Run sonic-mgmt platform API tests which depend on these facts.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)