Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[accton] Add sensors.conf to multiple models #7494

Merged
merged 1 commit into from
May 12, 2021

Conversation

seanwu-ec
Copy link
Contributor

@seanwu-ec seanwu-ec commented Apr 30, 2021

Why I did it

Improve readability of show environment output.

How I did it

In all sensors.conf, give the customized labels according to HW specifications for each model.

How to verify it

Installed the built sonic bin and check the prompt of $ show environment or $ sensors, see if every label works nicely.
e.g., on model accton/as5812-54t

admin@sonic:~$ sensors
lm75-i2c-16-49
Adapter: i2c-1-mux (chan_id 6)
Main Board Temperature:  +31.0 C  (high = +80.0 C, hyst = +75.0 C)

lm75-i2c-17-4a
Adapter: i2c-1-mux (chan_id 7)
Main Board Temperature:  +31.5 C  (high = +80.0 C, hyst = +75.0 C)

coretemp-isa-0000
Adapter: ISA adapter
Core 0:       +30.0 C  (high = +98.0 C, crit = +98.0 C)
Core 1:       +30.0 C  (high = +98.0 C, crit = +98.0 C)
Core 2:       +32.0 C  (high = +98.0 C, crit = +98.0 C)
Core 3:       +31.0 C  (high = +98.0 C, crit = +98.0 C)

ym2401-i2c-11-58
Adapter: i2c-1-mux (chan_id 1)
PSU 1 Voltage:      +0.00 V
PSU 1 Fan:            0 RPM
PSU 1 Temperature:   +0.0 C
PSU 1 Power:         0.00 W
PSU 1 Current:      +0.00 A

ym2401-i2c-12-5b
Adapter: i2c-1-mux (chan_id 2)
PSU 2 Voltage:     +11.97 V
PSU 2 Fan:         12800 RPM
PSU 2 Temperature:  +28.0 C
PSU 2 Power:        71.00 W
PSU 2 Current:      +5.95 A

cpr_4011_4mxx-i2c-11-3c
Adapter: i2c-1-mux (chan_id 1)
PSU 1 Voltage In:   +0.00 V
PSU 1 Voltage Out:  +0.00 V
PSU 1 Fan:            0 RPM
PSU 1 Temperature:   +0.0 C
PSU 1 Power In:      0.00 W
PSU 1 Power Out:     0.00 W
PSU 1 Current In:   +0.00 A
PSU 1 Current Out:  +0.00 A

cpr_4011_4mxx-i2c-12-3f
Adapter: i2c-1-mux (chan_id 2)
PSU 2 Voltage In:   +0.00 V
PSU 2 Voltage Out:  +0.00 V
PSU 2 Fan:            0 RPM
PSU 2 Temperature:   +0.0 C
PSU 2 Power In:      0.00 W
PSU 2 Power Out:     0.00 W
PSU 2 Current In:   +0.00 A
PSU 2 Current Out:  +0.00 A

lm75-i2c-15-48
Adapter: i2c-1-mux (chan_id 5)
Main Board Temperature:  +29.5 C  (high = +80.0 C, hyst = +75.0 C)

as5812_54t_fan-isa-0000
Adapter: ISA adapter
Fan 1 Front:    FAULT
Fan 2 Front:    FAULT
Fan 3 Front:    FAULT
Fan 4 Front:    FAULT
Fan 5 Front:    FAULT
Fan 1 Rear:     FAULT
Fan 2 Rear:     FAULT
Fan 3 Rear:     FAULT
Fan 4 Rear:     FAULT
Fan 5 Rear:     FAULT

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

Add sensors.conf to multiple Accton models.

A picture of a cute animal (not mandatory but encouraged)

All 15 sensors.conf have been verified with their matching machine.

Signed-off-by: Sean Wu <[email protected]>
@seanwu-ec seanwu-ec requested a review from jleveque as a code owner April 30, 2021 05:46
@ghost
Copy link

ghost commented Apr 30, 2021

CLA assistant check
All CLA requirements met.

@jleveque
Copy link
Contributor

jleveque commented May 7, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jleveque jleveque merged commit 9b4ed6e into sonic-net:master May 12, 2021
qiluo-msft pushed a commit that referenced this pull request May 24, 2021
#### Why I did it
Improve readability of `show environment` output.

#### How I did it
In all sensors.conf, give the customized labels according to HW specifications for each model.

Signed-off-by: Sean Wu <[email protected]>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
#### Why I did it
Improve readability of `show environment` output.

#### How I did it
In all sensors.conf, give the customized labels according to HW specifications for each model.

Signed-off-by: Sean Wu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants