[sonic-psud] Depend on sonic-platform-common #7182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jleveque is the submodule PR marked to be for 202012? |
liat-grozovik
approved these changes
Mar 30, 2021
qiluo-msft
reviewed
Mar 30, 2021
| @@ -13,7 +13,7 @@ SONIC_PYTHON_WHEELS += $(SONIC_PSUD_PY2) | |||
|
|
|||
| SONIC_PSUD_PY3 = sonic_psud-1.0-py3-none-any.whl | |||
| $(SONIC_PSUD_PY3)_SRC_PATH = $(SRC_PATH)/sonic-platform-daemons/sonic-psud | |||
| $(SONIC_PSUD_PY3)_DEPENDS = $(SONIC_PY_COMMON_PY3) $(SONIC_PSUD_PY2) | |||
| $(SONIC_PSUD_PY3)_DEPENDS = $(SONIC_PY_COMMON_PY3) $(SONIC_PLATFORM_COMMON_PY3) $(SONIC_PSUD_PY2) | |||
There was a problem hiding this comment.
Why a PY3 depends on PY2? #Closed
There was a problem hiding this comment.
To prevent building the Python 2 and Python 3 packages simultaneously, which can cause build issues.
qiluo-msft
reviewed
Mar 30, 2021
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| SONIC_PSUD_PY2 = sonic_psud-1.0-py2-none-any.whl | |||
| $(SONIC_PSUD_PY2)_SRC_PATH = $(SRC_PATH)/sonic-platform-daemons/sonic-psud | |||
| $(SONIC_PSUD_PY2)_DEPENDS = $(SONIC_PY_COMMON_PY2) | |||
| $(SONIC_PSUD_PY2)_DEPENDS = $(SONIC_PY_COMMON_PY2) $(SONIC_PLATFORM_COMMON_PY2) | |||
There was a problem hiding this comment.
Why we still have PY2? #Closed
There was a problem hiding this comment.
Because some vendors have not yet ported their platform APIs to Python 3. :( We are allowing them until the next release to do so.
daall
pushed a commit
that referenced
this pull request
Mar 31, 2021
Unit tests for psud depend on sonic-platform-common as of sonic-net/sonic-platform-daemons#154
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
Unit tests for psud depend on sonic-platform-common as of sonic-net/sonic-platform-daemons#154
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
Unit tests for psud depend on sonic-platform-common as of sonic-net/sonic-platform-daemons#154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Unit tests for psud depend on sonic-platform-common as of sonic-net/sonic-platform-daemons#154
How I did it
Add dependency in sonic-thermalctld.mk makefile.
How to verify it
Ensure build passes once sonic-net/sonic-platform-daemons#154 is included in a submodule update.
Which release branch to backport (provide reason below if selected)