[202012][sonic-config-engine] Parse AutoNegotiation element from LinkMetadata section of minigraph file #7166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Metadata section of minigraph file (#7031) Parse the value `AutoNegotiation` element from the `LinkMetadata` section of minigraph file. If the element is present, an `autoneg` key will be added to the port in the `PORT` table of Config DB with a value of either `off` or `on` If an `autoneg` value is present in port_config.ini, the value from the minigraph will take precedence, overriding that value. Also remove `AutoNegotiation` and `EnableAutoNegotiation` elements from the `DeviceInfo` section, as we will use this data in the `LinkMetadata` section to determine whether to enable auto-negotiation for a port.
jleveque
added
Enhancement ➕
sonic-cfggen
4 tasks
yxieca
approved these changes
Mar 26, 2021
|
can you check build issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7031 to the 202012 branch
Why I did it
To enable parsing the
AutoNegotiationelement from the LinkMetadata section of minigraph fileHow I did it
Parse the value
AutoNegotiationelement from theLinkMetadatasection of minigraph file. If the element is present, anautonegkey will be added to the port in thePORTtable of Config DB with a value of either0or1If an
autonegvalue is present in port_config.ini, the value from the minigraph will take precedence, overriding that value.Also remove
AutoNegotiationandEnableAutoNegotiationelements from theDeviceInfosection, as we will use this data in theLinkMetadatasection to determine whether to enable auto-negotiation for a port.How to verify it
Added unit tests to validate the behavior described above
Which release branch to backport (provide reason below if selected)