Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DellEMC: Z9332F - Watchdog support, add platform.json, new platform API implementation and fixes #6988

Merged
merged 2 commits into from
Mar 10, 2021

Conversation

vpsubramaniam
Copy link
Contributor

@vpsubramaniam vpsubramaniam commented Mar 8, 2021

Why I did it

To incorporate the below changes in DellEMC Z9332F platform.

  • Implement watchdog support
  • Implement ‘get_position_in_parent’, ‘is_replaceable’ methods for all device types
  • Add platform.json file

How I did it

  • Implemented watchdog platform API support
  • Implement the platform API methods in the respective device files
  • Change return type of SFP methods to match specification in sonic_platform_common/sfp_base.py
  • Added platform.json file in device directory.

How to verify it

  • With a python script verified the platform API return values.
  • Verified 'show platform fan' and 'show platform temperature' command outputs

Logs: Unit testing logs.txt

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

DellEMC: Z9332F - Watchdog support, add platform.json, new platform API implementation and fixes

A picture of a cute animal (not mandatory but encouraged)

@ghost
Copy link

ghost commented Mar 8, 2021

CLA assistant check
All CLA requirements met.

@lgtm-com
Copy link

lgtm-com bot commented Mar 8, 2021

This pull request introduces 2 alerts when merging db21d19 into 653bd08 - view on LGTM.com

new alerts:

  • 2 for Unused import

@vpsubramaniam
Copy link
Contributor Author

@jleveque, can you merge this to 202012 branch?

daall pushed a commit that referenced this pull request May 5, 2021
…PI implementation and fixes (#6988)

Incorporate the below changes in DellEMC Z9332F platform:

- Implemented watchdog platform API support
- Implement ‘get_position_in_parent’, ‘is_replaceable’ methods for all device types
- Change return type of SFP methods to match specification in sonic_platform_common/sfp_base.py
- Added platform.json file in device directory.

Co-authored-by: V P Subramaniam <[email protected]>
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
…PI implementation and fixes (sonic-net#6988)

Incorporate the below changes in DellEMC Z9332F platform:

- Implemented watchdog platform API support
- Implement ‘get_position_in_parent’, ‘is_replaceable’ methods for all device types
- Change return type of SFP methods to match specification in sonic_platform_common/sfp_base.py
- Added platform.json file in device directory.

Co-authored-by: V P Subramaniam <[email protected]>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
…PI implementation and fixes (sonic-net#6988)

Incorporate the below changes in DellEMC Z9332F platform:

- Implemented watchdog platform API support
- Implement ‘get_position_in_parent’, ‘is_replaceable’ methods for all device types
- Change return type of SFP methods to match specification in sonic_platform_common/sfp_base.py
- Added platform.json file in device directory.

Co-authored-by: V P Subramaniam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants