Change the order of stopping dependent services of SWSS on master #6755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Bitton <[email protected]>
liat-grozovik
approved these changes
Feb 14, 2021
|
@shlomibitton your PR description is missing to which branch the fix is required. Please add. |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
shlomibitton
changed the title
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
daall
pushed a commit
that referenced
this pull request
Feb 16, 2021
- What I did All SWSS dependent services should stop before SWSS service to avoid future possible issues. For example 'teamd' service will stop before to allow the driver unload netdev gracefully. This is to stop all LAG's before restarting syncd service when running 'config reload' command. - How I did it Change the order of dependent services of SWSS. - How to verify it Run 'config reload' command. Previously the operation failed when a large number of PortChannel configured on the system. Signed-off-by: Shlomi Bitton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shlomi Bitton [email protected]
- What I did
All SWSS dependent services should stop before SWSS service to avoid future possible issues.
For example 'teamd' service will stop before to allow the driver unload netdev gracefully.
This is to stop all LAG's before restarting syncd service when running 'config reload' command.
- How I did it
Change the order of dependent services of SWSS.
- How to verify it
Run 'config reload' command.
Previously the operation failed when a large number of PortChannel configured on the system.
- Description for the changelog
Change the order of the service stop to be the opposite order of the start.