Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bgpcfgd] Add unit tests #6634

Merged
merged 8 commits into from
Feb 2, 2021
Merged

[Bgpcfgd] Add unit tests #6634

merged 8 commits into from
Feb 2, 2021

Conversation

shi-su
Copy link
Contributor

@shi-su shi-su commented Feb 1, 2021

- Why I did it
Add unit tests for bgpcfgd

- How I did it
Add unit tests for bgpcfgd and fix a minor bug in manager_intf.py found in testing

Test coverage with this PR

Name                             Stmts   Miss  Cover
----------------------------------------------------
bgpcfgd/__init__.py                  0      0   100%
bgpcfgd/__main__.py                  3      3     0%
bgpcfgd/config.py                   69      0   100%
bgpcfgd/directory.py                63      0   100%
bgpcfgd/frr.py                      49      1    98%
bgpcfgd/log.py                      15      2    87%
bgpcfgd/main.py                     53     53     0%
bgpcfgd/manager.py                  41     21    49%
bgpcfgd/managers_allow_list.py     425     29    93%
bgpcfgd/managers_bbr.py             84      0   100%
bgpcfgd/managers_bgp.py            192     33    83%
bgpcfgd/managers_db.py               9      0   100%
bgpcfgd/managers_intf.py            33      0   100%
bgpcfgd/managers_setsrc.py          44      7    84%
bgpcfgd/runner.py                   44     44     0%
bgpcfgd/template.py                 64      8    88%
bgpcfgd/utils.py                    19     14    26%
bgpcfgd/vars.py                      1      0   100%
----------------------------------------------------
TOTAL                             1208    215    82%

- How to verify it
Run unit tests locally and confirm all passed.

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@shi-su shi-su requested a review from a team as a code owner February 1, 2021 17:47
@lguohan
Copy link
Collaborator

lguohan commented Feb 1, 2021

can you provide the code coverge data?

@shi-su
Copy link
Contributor Author

shi-su commented Feb 1, 2021

can you provide the code coverge data?

Added coverage data in the PR description.

@shi-su shi-su merged commit ee18483 into sonic-net:master Feb 2, 2021
lguohan pushed a commit that referenced this pull request Feb 3, 2021
Add unit tests for bgpcfgd and fix a minor bug in manager_intf.py found in testing
deran1980 pushed a commit to deran1980/sonic-buildimage that referenced this pull request Feb 4, 2021
Add unit tests for bgpcfgd and fix a minor bug in manager_intf.py found in testing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants