-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mellanox] [platform API] Fix “local variable 'label_port' referenced before assignment” error #6419
Conversation
retest vsimage please |
@keboliu: I assume we should also cherry-pick this into the 202012 branch, no? |
But what about 202012? I assume the rare issue exists there too, no (we just created this branch at the end of December)? |
202012 also need to be included, I thought 202012 will be automatically synced with the master for a period |
… before assignment” error (#6419) In rare case can see that xcvrd failed due to "UnboundLocalError: local variable 'label_port' referenced before assignment" Init "label_port" as None at the beginning of the function, to avoid the case that "label_port" not assigned.
Just to be certain that the PR gets included in the branch, please add the "Request for 202012 branch" to any relevant PRs so that we can track. |
… before assignment” error (#6419) In rare case can see that xcvrd failed due to "UnboundLocalError: local variable 'label_port' referenced before assignment" Init "label_port" as None at the beginning of the function, to avoid the case that "label_port" not assigned.
- Why I did it
In rare case can see that xcvrd failed due to "UnboundLocalError: local variable 'label_port' referenced before assignment"
- How I did it
Init "label_port" as None at the beginning of the function, to avoid the case that "label_port" not assigned.
- How to verify it
run SFP related test on Mellanox platforms.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)