Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPB][YANG-models] extended regex pattern according to Mellanox systems speeds requirements #6279

Merged

Conversation

vadymhlushko-mlnx
Copy link
Contributor

@vadymhlushko-mlnx vadymhlushko-mlnx commented Dec 23, 2020

- Why I did it

All Mellanox platforms require DPB modes with a specific set of speeds example

- How I did it

Extended regex pattern inside YANG model.
Supported platforms: SN2010, SN2100, SN2410, SN2700, SN3420, SN3700, SN3700C, SN3800, SN4600C, SN4410, SN4700

- How to verify it

Manually tested DPB CLI on all platform with all modes

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

liat-grozovik
liat-grozovik previously approved these changes Dec 28, 2020
@liat-grozovik
Copy link
Collaborator

retest vs please

@liat-grozovik
Copy link
Collaborator

retest vsimage please

@liat-grozovik liat-grozovik changed the title [DPB][MLNX][YANG-models] extended regex pattern according to MLNX systems speeds requirements [DPB][YANG-models] extended regex pattern according to MLNX systems speeds requirements Dec 28, 2020
@vadymhlushko-mlnx
Copy link
Contributor Author

retest vsimage please

@zhenggen-xu
Copy link
Collaborator

I think sonic-breakout_cfg.yang should be removed and backend should check the speed by platform.json, and not limit this into yang models. This is going to be accommodated by sonic-net/sonic-utilities#1020 and new PR(s). sonic-port.yang changes are fine.

@praveen-li

@liat-grozovik
Copy link
Collaborator

I think sonic-breakout_cfg.yang should be removed and backend should check the speed by platform.json, and not limit this into yang models. This is going to be accommodated by Azure/sonic-utilities#1020 and new PR(s). sonic-port.yang changes are fine.

@praveen-li

I believe this approach is better but it will take time until it will be available. Meanwhile we are blocked with many PRs.
As of that i think this change should be merged, later on it will be not relevant as you will do the changes mentioned above.
Can we proceed with this PR approval and merge?

@lguohan
Copy link
Collaborator

lguohan commented Jan 5, 2021

@zhenggen-xu , what are the new PRs you mentioned?

@zhenggen-xu
Copy link
Collaborator

zhenggen-xu commented Jan 6, 2021

OK, we can get this in, we will have new PR(s) to remove the sonic-breakout_cfg.yang and make the configMgmt logic to check the breakout mode instead.

zhenggen-xu
zhenggen-xu previously approved these changes Jan 6, 2021
Copy link
Collaborator

@praveen-li praveen-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liat-grozovik liat-grozovik changed the title [DPB][YANG-models] extended regex pattern according to MLNX systems speeds requirements [DPB][YANG-models] extended regex pattern according to Mellanox systems speeds requirements Jan 13, 2021
@vadymhlushko-mlnx
Copy link
Contributor Author

@praveen-li could you please review the last changes?

Copy link
Collaborator

@praveen-li praveen-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, note it may be possible that we may deprecate BRK_CFG Yang model later. Thx.

@vadymhlushko-mlnx
Copy link
Contributor Author

Retest vsimage please

@liat-grozovik liat-grozovik merged commit 1ea5fd7 into sonic-net:master Jan 17, 2021
@vadymhlushko-mlnx vadymhlushko-mlnx deleted the dpb_mlnx_speeds_yang_models branch January 18, 2021 08:22
@vadymhlushko-mlnx vadymhlushko-mlnx restored the dpb_mlnx_speeds_yang_models branch February 1, 2021 15:02
@vadymhlushko-mlnx vadymhlushko-mlnx deleted the dpb_mlnx_speeds_yang_models branch February 1, 2021 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants