[slave-buster] Armhf sairedis build fix #6239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doxygen https://github.com/opencomputeproject/SAI/blob/master/Makefile#L23 SAI submodule in libsairedis builds meta using doxygen Debian buster doxygen for ARMHF (32bit) fails to recursively read subdirectories to parse the header files. This issue is described at https://bugs.launchpad.net/qemu/+bug/1805913 The solution to this is to add FILE_OFFSET_BITS to 64 as desribed at https://bugzilla.kernel.org/show_bug.cgi?id=205957 This issue is not seen in stretch which has glibc 2.24 and is seen only on buster which has glibc version 2.28. The above bugs needs to be tracked to get rid of this PR change, once debian moves forward to next version. This PR addresses the readdir() issue for 32bit arch, by adding cflag _FILE_OFFSET_BITS=64 through cmake definition to the doxygen source downloaded from the debian buster. Signed-off-by: Antony Rheneus <[email protected]>
antony-rheneus
force-pushed
the
sairedis-dependency-fix
branch
from
36640e6 to
ecf28cc
Compare
lguohan
approved these changes
Dec 17, 2020
Sabareesh-Kumar-Anandan
pushed a commit
to Sabareesh-Kumar-Anandan/sonic-buildimage
that referenced
this pull request
Dec 18, 2020
Aspell check in sairedis SAI submodule in armhf(32-bit) fails with lang dictionary not found error. (https://github.com/opencomputeproject/SAI/blob/master/meta/style.pm#L58) This issue is described at https://bugs.launchpad.net/qemu/+bug/1805913 and similar to sonic-net#6239 Re-installing aspell language dictionary in slave docker resolves this issue. Signed-off-by: Sabareesh Kumar Anandan <[email protected]>
3 tasks
lguohan
pushed a commit
that referenced
this pull request
Dec 19, 2020
Aspell check in sairedis SAI submodule in armhf(32-bit) fails with lang dictionary not found error. (https://github.com/opencomputeproject/SAI/blob/master/meta/style.pm#L58) This issue is described at https://bugs.launchpad.net/qemu/+bug/1805913 and similar to #6239 Re-installing aspell language dictionary in slave docker resolves this issue. Signed-off-by: Sabareesh Kumar Anandan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doxygen https://github.com/opencomputeproject/SAI/blob/master/Makefile#L23
SAI submodule in libsairedis builds meta using doxygen
Debian buster doxygen for ARMHF (32bit) fails to recursively
read subdirectories to parse the header files.
This issue is described at https://bugs.launchpad.net/qemu/+bug/1805913
The solution to this is to add FILE_OFFSET_BITS to 64 as desribed at
https://bugzilla.kernel.org/show_bug.cgi?id=205957
This issue is not seen in stretch which has glibc 2.24 and is seen only
on buster which has glibc version 2.28. The above bugs needs to be
tracked to get rid of this PR change, once debian moves forward to next
version.
This PR addresses the readdir() issue for 32bit arch, by adding
cflag _FILE_OFFSET_BITS=64 through cmake definition to the doxygen
source downloaded from the debian buster.
Signed-off-by: Antony Rheneus [email protected]
- Why I did it
- How I did it
- How to verify it
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)